Catch exceptions if Exif is malformed (5ab7d37d) · Commits · e / os / android_frameworks_base

packages/WallpaperCropper/src/com/android/photos/BitmapRegionTileSource.java

+6 −0

Original line number	Diff line number	Diff line
		@@ -245,6 +245,9 @@ public class BitmapRegionTileSource implements TiledImageRenderer.TileSource {
		try {
		ei.readExif(mPath);
		return true;
		} catch (NullPointerException e) {
		Log.w("BitmapRegionTileSource", "reading exif failed", e);
		return false;
		} catch (IOException e) {
		Log.w("BitmapRegionTileSource", "getting decoder failed", e);
		return false;
		@@ -311,6 +314,9 @@ public class BitmapRegionTileSource implements TiledImageRenderer.TileSource {
		} catch (IOException e) {
		Log.e("BitmapRegionTileSource", "Failed to load URI " + mUri, e);
		return false;
		} catch (NullPointerException e) {
		Log.e("BitmapRegionTileSource", "Failed to read EXIF for URI " + mUri, e);
		return false;
		} finally {
		Utils.closeSilently(is);
		}

+3 −0

Original line number	Diff line number	Diff line
		@@ -271,6 +271,9 @@ public class WallpaperCropActivity extends Activity {
		}
		} catch (IOException e) {
		Log.w(LOGTAG, "Getting exif data failed", e);
		} catch (NullPointerException e) {
		// Sometimes the ExifInterface has an internal NPE if Exif data isn't valid
		Log.w(LOGTAG, "Getting exif data failed", e);
		} finally {
		Utils.closeSilently(bis);
		Utils.closeSilently(is);