Commit 5a874c53 authored Jan 06, 2025 by Riddle Hsu

Do not abort empty remote transition from TaskFragmentOrganizer

The implementation of TaskFragmentOrganizer may expect to always
handle the remote transition requested by itself. For example,
the organizer may add some callbacks to clear the related instances
after the transition is handled.

Fix: 387353796
Flag: EXEMPT bugfix
Test: Enable "Swipe to access Google app".
      Toggle "Dark theme" from notification panel.
      Run below commands (GC and dump) immediately:
        adb shell kill -10 $homePid
        adb shell dumpsys meminfo -a $homeProc | grep Activities
      The instance count should be 1.
Change-Id: Iedcd1ba4d5aaab6d43f9eba9238f3ea62c9d07a2

parent e4046a28

services/core/java/com/android/server/wm/WindowOrganizerController.java

+4 −1

Original line number	Diff line number	Diff line
		@@ -595,7 +595,10 @@ class WindowOrganizerController extends IWindowOrganizerController.Stub
		}
		final ActionChain chain = mService.mChainTracker.start("tfTransact", transition);
		final int effects = applyTransaction(wct, -1 /* syncId */, chain, caller, deferred);
		if (effects == TRANSACT_EFFECTS_NONE && transition.mParticipants.isEmpty()) {
		if (effects == TRANSACT_EFFECTS_NONE && transition.mParticipants.isEmpty()
		// Always send the remote transition even if it is no-op because the remote
		// handler may still want to handle it.
		&& remoteTransition == null) {
		transition.abort();
		return;
		}