Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59cf9aa2 authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Guard against native crash due to null Surface 

Bug: 77874529
Test: record video, mini CTS
Change-Id: I00815fa334a9701e344b263e62549655299013cf
parent 575fc02e

media/jni/android_media_MediaCodec.cpp

+5 −0
Original line number Diff line number Diff line
@@ -1261,6 +1261,11 @@ static void android_media_MediaCodec_setInputSurface( 
    sp<PersistentSurface> persistentSurface =

        android_media_MediaCodec_getPersistentInputSurface(env, object);



    if (persistentSurface == NULL) {

        throwExceptionAsNecessary(

                env, BAD_VALUE, ACTION_CODE_FATAL, "input surface not valid");

        return;

    }

    status_t err = codec->setInputSurface(persistentSurface);

    if (err != NO_ERROR) {

        throwExceptionAsNecessary(env, err);