Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 597dbb07 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove mis-specified @GuardedBy("mMethodMap")

This is a safe no-op CL that removes mis-specified

  @GuardedBy("mMethodMap")

annotations from InputMethodManagerService, which was added while we
were trying to introduce proto-based event logging [1].  Otherwise our
lint would keep false-alarming even if those methods were correctly
used.

Anyway, this CL should have zero impact on generated code since
@GuardedBy annotation is used only for static code analysis.

 [1]: Icbfb8c11e882f29eb45dea9d4c23315c48e9d619
      5e68eeac

Bug: 154348613
Bug: 177462676
Test: presubmit
Change-Id: I92fb0f9f8957ad0649bfad6196356bb3f9698e04
parent a9333598
Loading
Loading
Loading
Loading
+0 −2
Original line number Diff line number Diff line
@@ -4101,7 +4101,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
     */
    @BinderThread
    @Override
    @GuardedBy("mMethodMap")
    public void startProtoDump(byte[] protoDump, int source, String where,
            IVoidResultCallback resultCallback) {
        CallbackUtils.onResult(resultCallback, () -> {
@@ -4198,7 +4197,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
        });
    }

    @GuardedBy("mMethodMap")
    private void dumpDebug(ProtoOutputStream proto, long fieldId) {
        synchronized (mMethodMap) {
            final long token = proto.start(fieldId);