Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 593657f2 authored by Jean Chen's avatar Jean Chen Committed by Daniel Norman
Browse files

fix(magnify_ime): Panel toggles don't update when the same setting is changed... 

fix(magnify_ime): Panel toggles don't update when the same setting is changed in magnification settings

Bug: 413441693
Flag: com.android.server.accessibility.enable_magnification_magnify_nav_bar_and_ime
Test: manual
Test: atest WindowMagnificationSettingsTest
Change-Id: I096dcb3961a4bda40943b1262decbf6cd208ce0f
parent 3a4fc5af

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationSettings.java

+65 −18
Original line number Diff line number Diff line
@@ -104,8 +104,6 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
    private ImageButton mFullScreenButton;

    private int mLastSelectedButtonIndex = MagnificationSize.DEFAULT;

    private boolean mAllowDiagonalScrolling = false;

    private boolean mAllowMagnifyTyping = false;

    private boolean mAllowMagnifyKeyboard = false;



    /**

     * Amount by which magnification scale changes compared to seekbar in settings.
@@ -116,7 +114,12 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 


    private WindowMagnificationSettingsCallback mCallback;



    private ContentObserver mMagnificationCapabilityObserver;

    @VisibleForTesting

    ContentObserver mMagnificationCapabilityObserver;

    @VisibleForTesting

    ContentObserver mMagnifyTypingObserver;

    @VisibleForTesting

    ContentObserver mMagnifyKeyboardObserver;



    @Retention(RetentionPolicy.SOURCE)

    @IntDef({
@@ -151,17 +154,6 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
                Settings.Secure.ACCESSIBILITY_ALLOW_DIAGONAL_SCROLLING, 1,

                UserHandle.USER_CURRENT) == 1;



        if (Flags.enableMagnificationMagnifyNavBarAndIme()) {

            mAllowMagnifyTyping = mSecureSettings.getIntForUser(

                    Settings.Secure.ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED, 1,

                    UserHandle.USER_CURRENT) == 1;



            mAllowMagnifyKeyboard = mSecureSettings.getIntForUser(

                    Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME,

                    AccessibilityUtils.getMagnificationMagnifyKeyboardDefaultValue(mContext),

                    UserHandle.USER_CURRENT) == 1;

        }



        mParams = createLayoutParams(context);

        mWindowInsetChangeRunnable = this::onWindowInsetChanged;
@@ -179,6 +171,28 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
                });

            }

        };



        if (Flags.enableMagnificationMagnifyNavBarAndIme()) {

            mMagnifyTypingObserver = new ContentObserver(

                    mContext.getMainThreadHandler()) {

                @Override

                public void onChange(boolean selfChange) {

                    mSettingView.post(() -> {

                        updateMagnifyTypingUI();

                    });

                }

            };



            mMagnifyKeyboardObserver = new ContentObserver(

                    mContext.getMainThreadHandler()) {

                @Override

                public void onChange(boolean selfChange) {

                    mSettingView.post(() -> {

                        updateMagnifyKeyboardUI();

                    });

                }

            };

        }

    }



    private class ZoomSeekbarChangeListener implements
@@ -336,6 +350,10 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 


        // Unregister observer before removing view

        mSecureSettings.unregisterContentObserverSync(mMagnificationCapabilityObserver);

        if (Flags.enableMagnificationMagnifyNavBarAndIme()) {

            mSecureSettings.unregisterContentObserverSync(mMagnifyTypingObserver);

            mSecureSettings.unregisterContentObserverSync(mMagnifyKeyboardObserver);

        }

        mWindowManager.removeView(mSettingView);

        mIsVisible = false;

        if (resetPosition) {
@@ -387,6 +405,8 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
    private void showSettingPanel(boolean resetPosition) {

        if (!mIsVisible) {

            updateUIControlsIfNeeded();

            updateMagnifyTypingUI();

            updateMagnifyKeyboardUI();

            setScaleSeekbar(getMagnificationScale());

            if (resetPosition) {

                mDraggableWindowBounds.set(getDraggableWindowBounds());
@@ -401,6 +421,18 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
                    mMagnificationCapabilityObserver,

                    UserHandle.USER_CURRENT);



            if (Flags.enableMagnificationMagnifyNavBarAndIme()) {

                mSecureSettings.registerContentObserverForUserSync(

                        Settings.Secure.ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED,

                        mMagnifyTypingObserver,

                        UserHandle.USER_CURRENT);



                mSecureSettings.registerContentObserverForUserSync(

                        Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME,

                        mMagnifyKeyboardObserver,

                        UserHandle.USER_CURRENT);

            }



            // Exclude magnification switch button from system gesture area.

            setSystemGestureExclusion();

            mIsVisible = true;
@@ -437,12 +469,17 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 


    @VisibleForTesting

    boolean isMagnifyTypingEnabled() {

        return mAllowMagnifyTyping;

        return mSecureSettings.getIntForUser(

                Settings.Secure.ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED,

                1, UserHandle.USER_CURRENT) == 1;

    }



    @VisibleForTesting

    boolean isMagnifyKeyboardEnabled() {

        return mAllowMagnifyKeyboard;

        return mSecureSettings.getIntForUser(

                Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME,

                AccessibilityUtils.getMagnificationMagnifyKeyboardDefaultValue(mContext),

                UserHandle.USER_CURRENT) == 1;

    }



    /**
@@ -530,6 +567,16 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
        mSettingView.requestLayout();

    }



    private void updateMagnifyTypingUI() {

        mMagnifyTypingSwitch.setChecked(isMagnifyTypingEnabled());

        mSettingView.requestLayout();

    }



    private void updateMagnifyKeyboardUI() {

        mMagnifyKeyboardSwitch.setChecked(isMagnifyKeyboardEnabled());

        mSettingView.requestLayout();

    }



    private final BroadcastReceiver mScreenOffReceiver = new BroadcastReceiver() {

        @Override

        public void onReceive(Context context, Intent intent) {
@@ -574,7 +621,7 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
                    (LinearLayout) mSettingView.findViewById(R.id.magnifier_typing_view);

            mMagnifyTypingSwitch =

                    (MaterialSwitch) mSettingView.findViewById(R.id.magnifier_typing_switch);

            mMagnifyTypingSwitch.setChecked(mAllowMagnifyTyping);

            mMagnifyTypingSwitch.setChecked(isMagnifyTypingEnabled());

            mMagnifyTypingSwitch.setOnCheckedChangeListener(

                    (view, isChecked) -> setMagnifyTyping(isChecked));
@@ -582,7 +629,7 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
                    (LinearLayout) mSettingView.findViewById(R.id.magnifier_keyboard_view);

            mMagnifyKeyboardSwitch =

                    (MaterialSwitch) mSettingView.findViewById(R.id.magnifier_keyboard_switch);

            mMagnifyKeyboardSwitch.setChecked(mAllowMagnifyKeyboard);

            mMagnifyKeyboardSwitch.setChecked(isMagnifyKeyboardEnabled());

            mMagnifyKeyboardSwitch.setOnCheckedChangeListener(

                    (view, isChecked) -> setMagnifyKeyboard(isChecked));

        }

packages/SystemUI/tests/src/com/android/systemui/accessibility/WindowMagnificationSettingsTest.java

+128 −3
Original line number Diff line number Diff line
@@ -17,6 +17,8 @@ 
package com.android.systemui.accessibility;



import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_CAPABILITY;

import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED;

import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME;

import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MODE_ALL;

import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN;

import static android.provider.Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW;
@@ -75,6 +77,8 @@ import com.android.systemui.common.ui.view.SeekBarWithIconButtonsView.OnSeekBarW 
import com.android.systemui.res.R;

import com.android.systemui.util.settings.SecureSettings;



import com.google.android.material.materialswitch.MaterialSwitch;



import org.junit.After;

import org.junit.Before;

import org.junit.Test;
@@ -95,6 +99,8 @@ public class WindowMagnificationSettingsTest extends SysuiTestCase { 


    private ViewGroup mSettingView;

    private SeekBarWithIconButtonsView mZoomSeekbar;

    private MaterialSwitch mMagnifyTypingSwitch;

    private MaterialSwitch mMagnifyKeyboardSwitch;

    @Mock

    private AccessibilityManager mAccessibilityManager;

    @Mock
@@ -130,6 +136,10 @@ public class WindowMagnificationSettingsTest extends SysuiTestCase { 


        mSettingView = mWindowMagnificationSettings.getSettingView();

        mZoomSeekbar = mSettingView.findViewById(R.id.magnifier_zoom_slider);

        mMagnifyTypingSwitch =

                (MaterialSwitch) mSettingView.findViewById(R.id.magnifier_typing_switch);

        mMagnifyKeyboardSwitch =

                (MaterialSwitch) mSettingView.findViewById(R.id.magnifier_keyboard_switch);

        mCallbackMagnifierScaleCaptor = ArgumentCaptor.forClass(Float.class);

    }
@@ -454,7 +464,7 @@ public class WindowMagnificationSettingsTest extends SysuiTestCase { 
    }



    @Test

    public void showSettingsPanel_observerRegistered() {

    public void showSettingsPanel_magnificationCapabilityObserverRegistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);
@@ -468,7 +478,51 @@ public class WindowMagnificationSettingsTest extends SysuiTestCase { 
    }



    @Test

    public void hideSettingsPanel_observerUnregistered() {

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void showSettingsPanel_MagnifyTypingObserverRegistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();



        verify(mSecureSettings).registerContentObserverForUserSync(

                eq(ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED),

                any(ContentObserver.class),

                eq(UserHandle.USER_CURRENT));

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void showSettingsPanel_MagnifyKeyboardObserverRegistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();



        verify(mSecureSettings).registerContentObserverForUserSync(

                eq(ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME),

                any(ContentObserver.class),

                eq(UserHandle.USER_CURRENT));

    }



    @Test

    public void hideSettingsPanel_MagnificationCapabilityObserverUnregistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();

        mWindowMagnificationSettings.hideSettingPanel();



        verify(mSecureSettings).unregisterContentObserverSync(

                mWindowMagnificationSettings.mMagnificationCapabilityObserver);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void hideSettingsPanel_magnifyTypingObserverUnregistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);
@@ -476,7 +530,78 @@ public class WindowMagnificationSettingsTest extends SysuiTestCase { 
        mWindowMagnificationSettings.showSettingPanel();

        mWindowMagnificationSettings.hideSettingPanel();



        verify(mSecureSettings).unregisterContentObserverSync(any(ContentObserver.class));

        verify(mSecureSettings).unregisterContentObserverSync(

                mWindowMagnificationSettings.mMagnifyTypingObserver);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void hideSettingsPanel_magnifyKeyboardObserverUnregistered() {

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();

        mWindowMagnificationSettings.hideSettingPanel();



        verify(mSecureSettings).unregisterContentObserverSync(

                mWindowMagnificationSettings.mMagnifyKeyboardObserver);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void magnifyTypingSwitch_settingsValueIsTrue_switchIsChecked() {

        when(mSecureSettings.getIntForUser(eq(ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED),

                anyInt(), eq(UserHandle.USER_CURRENT))).thenReturn(1);

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();



        assertThat(mMagnifyTypingSwitch.isChecked()).isEqualTo(true);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void magnifyTypingSwitch_settingsValueIsFalse_switchIsUnchecked() {

        when(mSecureSettings.getIntForUser(eq(ACCESSIBILITY_MAGNIFICATION_FOLLOW_TYPING_ENABLED),

                anyInt(), eq(UserHandle.USER_CURRENT))).thenReturn(0);

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW);



        mWindowMagnificationSettings.showSettingPanel();



        assertThat(mMagnifyTypingSwitch.isChecked()).isEqualTo(false);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void magnifyKeyboardSwitch_settingsValueIsTrue_switchIsChecked() {

        when(mSecureSettings.getIntForUser(eq(ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME),

                anyInt(), eq(UserHandle.USER_CURRENT))).thenReturn(1);

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);



        mWindowMagnificationSettings.showSettingPanel();



        assertThat(mMagnifyKeyboardSwitch.isChecked()).isEqualTo(true);

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_MAGNIFICATION_MAGNIFY_NAV_BAR_AND_IME)

    public void magnifyKeyboardSwitch_settingsValueIsFalse_switchIsUnchecked() {

        when(mSecureSettings.getIntForUser(eq(ACCESSIBILITY_MAGNIFICATION_MAGNIFY_NAV_AND_IME),

                anyInt(), eq(UserHandle.USER_CURRENT))).thenReturn(0);

        setupMagnificationCapabilityAndMode(

                /* capability= */ ACCESSIBILITY_MAGNIFICATION_MODE_ALL,

                /* mode= */ ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);



        mWindowMagnificationSettings.showSettingPanel();



        assertThat(mMagnifyKeyboardSwitch.isChecked()).isEqualTo(false);

    }



    @Test