Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58aff579 authored by Behnam Heydarshahi's avatar Behnam Heydarshahi
Browse files

Prevent tile listening client leak 

When the same client is added for a second time, the adapter will no
longer create a new state flow.

Bug: 356880389
Flag: com.android.systemui.qs_new_tiles
Test: Manual. Log tile flows and verify they are unique per client.
Change-Id: I1f53ab18f278887cf010c19722fbffb66ae3e821
parent 4b85f98d

packages/SystemUI/src/com/android/systemui/qs/tiles/viewmodel/QSTileViewModelAdapter.kt

+2 −2
Original line number Diff line number Diff line
@@ -161,8 +161,8 @@ constructor( 
    override fun setListening(client: Any?, listening: Boolean) {

        client ?: return

        if (listening) {

            listeningClients.add(client)

            if (listeningClients.size == 1) {

            val clientWasNotAlreadyListening = listeningClients.add(client)

            if (clientWasNotAlreadyListening && listeningClients.size == 1) {

                stateJob =

                    qsTileViewModel.state

                        .filterNotNull()