Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 573d22a9 authored by Michael Wright's avatar Michael Wright
Browse files

Remove self-assignment from AutofillManagerService 

This lets us make the errorprone warning an error, prevent erroneous
future instances.

Bug: 217923092
Test: errorprone build
Change-Id: I600ec645fafbdb550c8d3a11b6c877a32aa454fb
parent 16451b0b

services/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ java_defaults { 
            "-Xep:HashtableContains:ERROR",

            "-Xep:FormatString:ERROR",

            "-Xep:ArrayHashCode:ERROR",

            "-Xep:SelfAssignment:ERROR",

            // NOTE: only enable to generate local patchfiles

            // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",

            // "-XepPatchLocation:/tmp/refaster/",

services/autofill/java/com/android/server/autofill/AutofillManagerService.java

+2 −2
Original line number Diff line number Diff line
@@ -1614,8 +1614,8 @@ public final class AutofillManagerService 
                @NonNull IBinder appCallback, @NonNull IResultReceiver receiver)

                throws RemoteException {

            final int userId = UserHandle.getCallingUserId();

            activityToken = Objects.requireNonNull(activityToken, "activityToken");

            appCallback = Objects.requireNonNull(appCallback, "appCallback");

            Objects.requireNonNull(activityToken, "activityToken");

            Objects.requireNonNull(appCallback, "appCallback");



            boolean restored = false;

            synchronized (mLock) {