Merge "[pm] clean up getRealPackageSetting" into main

        return mScanResult.mPkgSetting;

    }

    @Nullable

    public PackageSetting getRealPackageSetting() {

        // TODO: Fix this to have 1 mutable PackageSetting for scan/install. If the previous

        //  setting needs to be passed to have a comparison, hide it behind an immutable

        //  interface. There's no good reason to have 3 different ways to access the real

        //  PackageSetting object, only one of which is actually correct.

        PackageSetting realPkgSetting = isExistingSettingCopied()

                ? getScanRequestPackageSetting() : getScannedPackageSetting();

        if (realPkgSetting == null) {

            realPkgSetting = getScannedPackageSetting();

        }

        return realPkgSetting;

    }

    public boolean isExistingSettingCopied() {

        assertScanResultExists();

        return mScanResult.mExistingSettingCopied;