Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56172ee8 authored by Sanjana Sunil's avatar Sanjana Sunil
Browse files

PackageManagerService: Check for duplicate inactive factory packages 

If after a factory reset, APEX modules are updated, duplicate package
names are returned from the API - factory packages are added first and
then inactive factory packages leading to duplication.

After updating APEX modules, inactive factory packages would always be a
subset of factory packages. The fix adds inactive packages only if there
was no factory reset done.

Bug: 200519752
Bug: 200120056
Test: atest 'PackageManagerTest#testGetInstalledPackages_WithFactoryFlag_ContainsNoDuplicates'
Change-Id: I5b5469fc6879bbeee4dc2ea47b2046ab011a65ce
parent bf23230d

services/core/java/com/android/server/pm/ComputerEngine.java

+3 −3
Original line number Diff line number Diff line
@@ -1594,11 +1594,11 @@ public class ComputerEngine implements Computer { 
                list.addAll(mApexManager.getFactoryPackages());

            } else {

                list.addAll(mApexManager.getActivePackages());

            }

                if (listUninstalled) {

                    list.addAll(mApexManager.getInactivePackages());

                }

            }

        }

        return new ParceledListSlice<>(list);

    }