Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 560890ca authored by Wilson Wu's avatar Wilson Wu
Browse files

Add system property for ime event log 

Use a system property for DEBUG_IME_VISIBILITY
flag, so we can enable it for debugging.

Bug: 239501597
Test: Test as following steps:
      1. adb shell setprop persist.debug.imf_event 0
      2. adb shell am restart
      3. Observe logs
Change-Id: Ib419543f7f9b693a974aec7d520fff616bb2eafa
parent 49dc318d

core/java/android/view/inputmethod/ImeTracker.java

+1 −2
Original line number Diff line number Diff line
@@ -44,8 +44,7 @@ public interface ImeTracker { 
    String TAG = "ImeTracker";



    /** The debug flag for IME visibility event log. */

    // TODO(b/239501597) : Have a system property to control this flag.

    boolean DEBUG_IME_VISIBILITY = false;

    boolean DEBUG_IME_VISIBILITY = SystemProperties.getBoolean("persist.debug.imf_event", false);



    /** The message to indicate if there is no valid {@link Token}. */

    String TOKEN_NONE = "TOKEN_NONE";

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -48,12 +48,12 @@ import static android.view.Display.DEFAULT_DISPLAY; 
import static android.view.Display.INVALID_DISPLAY;

import static android.view.WindowManager.DISPLAY_IME_POLICY_HIDE;

import static android.view.WindowManager.DISPLAY_IME_POLICY_LOCAL;

import static android.view.inputmethod.ImeTracker.DEBUG_IME_VISIBILITY;



import static com.android.server.EventLogTags.IMF_HIDE_IME;

import static com.android.server.EventLogTags.IMF_SHOW_IME;

import static com.android.server.inputmethod.InputMethodBindingController.TIME_TO_RECONNECT;

import static com.android.server.inputmethod.InputMethodUtils.isSoftInputModeStateVisibleAllowed;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_IME_VISIBILITY;



import static java.lang.annotation.RetentionPolicy.SOURCE;

services/core/java/com/android/server/wm/DisplayContent.java

+1 −1
Original line number Diff line number Diff line
@@ -85,6 +85,7 @@ import static android.view.WindowManager.TRANSIT_CHANGE; 
import static android.view.WindowManager.TRANSIT_NONE;

import static android.view.WindowManager.TRANSIT_OPEN;

import static android.view.WindowManager.TRANSIT_TO_FRONT;

import static android.view.inputmethod.ImeTracker.DEBUG_IME_VISIBILITY;

import static android.window.DisplayAreaOrganizer.FEATURE_IME;

import static android.window.DisplayAreaOrganizer.FEATURE_ROOT;

import static android.window.DisplayAreaOrganizer.FEATURE_WINDOWED_MAGNIFICATION;
@@ -140,7 +141,6 @@ import static com.android.server.wm.WindowContainer.AnimationFlags.PARENTS; 
import static com.android.server.wm.WindowContainer.AnimationFlags.TRANSITION;

import static com.android.server.wm.WindowContainerChildProto.DISPLAY_CONTENT;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_DISPLAY;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_IME_VISIBILITY;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_INPUT_METHOD;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_LAYOUT;

import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_LAYOUT_REPEATS;

services/core/java/com/android/server/wm/WindowManagerDebugConfig.java

+0 −3
Original line number Diff line number Diff line
@@ -56,7 +56,4 @@ public class WindowManagerDebugConfig { 
    static final boolean SHOW_STACK_CRAWLS = false;

    static final boolean DEBUG_WINDOW_CROP = false;

    static final boolean DEBUG_UNKNOWN_APP_VISIBILITY = false;



    // TODO(b/239501597) : Have a system property to control this flag.

    public static final boolean DEBUG_IME_VISIBILITY = false;

}