Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55a68d16 authored by Chris Li's avatar Chris Li
Browse files

Fix EnterSplitScreenNotSupportNonResizable flaky 

Before, it called openQuickstep before canSplitScreen, but the later one
is also calling openQuickstep. This caused the recent is pressed twice
to introduce the flakness.

Test: atest WMShellFlickerTests:EnterSplitScreenNotSupportNonResizable
Bug: 182235458
Change-Id: Iba5af5114fd8883b73d78ac34e6f891ee8ca798f
parent 93595946

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt

+0 −2
Original line number Original line Diff line number Diff line
@@ -25,7 +25,6 @@ import com.android.server.wm.flicker.FlickerTestParameter 
import com.android.server.wm.flicker.FlickerTestParameterFactory

import com.android.server.wm.flicker.FlickerTestParameterFactory

import com.android.server.wm.flicker.dsl.FlickerBuilder

import com.android.server.wm.flicker.dsl.FlickerBuilder

import com.android.server.wm.flicker.helpers.canSplitScreen

import com.android.server.wm.flicker.helpers.canSplitScreen

import com.android.server.wm.flicker.helpers.openQuickstep

import com.android.server.wm.traces.parser.windowmanager.WindowManagerStateHelper

import com.android.server.wm.traces.parser.windowmanager.WindowManagerStateHelper

import com.android.wm.shell.flicker.dockedStackDividerIsInvisible

import com.android.wm.shell.flicker.dockedStackDividerIsInvisible

import com.android.wm.shell.flicker.helpers.SplitScreenHelper

import com.android.wm.shell.flicker.helpers.SplitScreenHelper
@@ -64,7 +63,6 @@ class EnterSplitScreenNotSupportNonResizable( 
                }

                }

            }

            }

            transitions {

            transitions {

                device.openQuickstep(wmHelper)

                if (device.canSplitScreen(wmHelper)) {

                if (device.canSplitScreen(wmHelper)) {

                    Assert.fail("Non-resizeable app should not enter split screen")

                    Assert.fail("Non-resizeable app should not enter split screen")

                }

                }