Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55726573 authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixes a visual issue with the Messaging Layout 

A messaging group would still look visible if all of its children
were hidden, which is incorrect. We instead regard it as measured too
small.

Test: add message notification with smart reply, click on smart reply
Change-Id: If5174f95038bf16022d935fd05f337969984f0c2
Fixes: 78214933
parent 150bafd2

core/java/com/android/internal/widget/MessagingGroup.java

+8 −1
Original line number Diff line number Diff line
@@ -276,9 +276,16 @@ public class MessagingGroup extends LinearLayout implements MessagingLinearLayou 
        boolean hasNormal = false;

        for (int i = mMessageContainer.getChildCount() - 1; i >= 0; i--) {

            View child = mMessageContainer.getChildAt(i);

            if (child.getVisibility() == GONE) {

                continue;

            }

            if (child instanceof MessagingLinearLayout.MessagingChild) {

                int type = ((MessagingLinearLayout.MessagingChild) child).getMeasuredType();

                if (type == MEASURED_TOO_SMALL) {

                boolean tooSmall = type == MEASURED_TOO_SMALL;

                final MessagingLinearLayout.LayoutParams lp =

                        (MessagingLinearLayout.LayoutParams) child.getLayoutParams();

                tooSmall |= lp.hide;

                if (tooSmall) {

                    if (hasNormal) {

                        return MEASURED_SHORTENED;

                    } else {