Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 54a90451 authored by Jackal Guo's avatar Jackal Guo
Browse files

Validate EXTRA_INSTALLER_PACKAGE_NAME 

When installing an app via ACTION_INSTALL_PACKAGE, the caller could
use this extra field to specify the installer package name. As using
PackageInstaller APIs, we should limit setting the installer package
name that is not the caller only when apps with INSTALL_PACKAGES
permission.

Bug: 236687884
Test: atest CtsPackageInstallTestCases
Test: manually using the PoC in the buganizer to ensure the symptom
      no longer exists.
Merged-In: I74eb4ea2e2733321b5fbf328a9835a3ca7d0dfa9
Change-Id: I99af469730756e9b5bc6ea4af51b1ea796164ce7
parent a890b22d

packages/PackageInstaller/src/com/android/packageinstaller/InstallStart.java

+18 −0
Original line number Diff line number Diff line
@@ -34,6 +34,8 @@ import android.os.Build; 
import android.os.Bundle;

import android.os.RemoteException;

import android.os.UserManager;

import android.text.TextUtils;

import android.util.EventLog;

import android.util.Log;



import java.util.Arrays;
@@ -96,6 +98,22 @@ public class InstallStart extends Activity { 
                mAbortInstall = true;

            }

        }



        final String installerPackageNameFromIntent = getIntent().getStringExtra(

                Intent.EXTRA_INSTALLER_PACKAGE_NAME);

        if (installerPackageNameFromIntent != null) {

            final String callingPkgName = getLaunchedFromPackage();

            if (!TextUtils.equals(installerPackageNameFromIntent, callingPkgName)

                    && mPackageManager.checkPermission(Manifest.permission.INSTALL_PACKAGES,

                    callingPkgName) != PackageManager.PERMISSION_GRANTED) {

                Log.e(LOG_TAG, "The given installer package name " + installerPackageNameFromIntent

                        + " is invalid. Remove it.");

                EventLog.writeEvent(0x534e4554, "236687884", getLaunchedFromUid(),

                        "Invalid EXTRA_INSTALLER_PACKAGE_NAME");

                getIntent().removeExtra(Intent.EXTRA_INSTALLER_PACKAGE_NAME);

            }

        }



        if (mAbortInstall) {

            setResult(RESULT_CANCELED);

            finish();