Correctly set the alpha of a hardware layer before drawing it. (54229ee5) · Commits · e / os / android_frameworks_base

core/java/android/view/ViewGroup.java

+2 −6

Original line number	Diff line number	Diff line
		@@ -2444,17 +2444,12 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager
		layerType != LAYER_TYPE_NONE) {
		layerFlags \|= Canvas.CLIP_TO_LAYER_SAVE_FLAG;
		}
		if (layerType != LAYER_TYPE_NONE) {
		child.mLayerPaint.setAlpha(multipliedAlpha);
		} else {
		if (layerType == LAYER_TYPE_NONE) {
		canvas.saveLayerAlpha(sx, sy, sx + cr - cl, sy + cb - ct,
		multipliedAlpha, layerFlags);
		}
		} else {
		// Alpha is handled by the child directly, clobber the layer's alpha
		if (layerType != LAYER_TYPE_NONE) {
		child.mLayerPaint.setAlpha(255);
		}
		child.mPrivateFlags \|= ALPHA_SET;
		}
		}
		@@ -2485,6 +2480,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager
		if (layerType == LAYER_TYPE_HARDWARE) {
		final HardwareLayer layer = child.getHardwareLayer();
		if (layer != null && layer.isValid()) {
		child.mLayerPaint.setAlpha((int) (alpha * 255));
		((HardwareCanvas) canvas).drawHardwareLayer(layer, 0, 0, child.mLayerPaint);
		layerRendered = true;
		} else {

tests/HwAccelerationTest/AndroidManifest.xml

+9 −0

Original line number	Diff line number	Diff line
		@@ -79,6 +79,15 @@
		</intent-filter>
		</activity>

		<activity
		android:name="ViewLayersActivity4"
		android:label="_ViewLayers4">
		<intent-filter>
		<action android:name="android.intent.action.MAIN" />
		<category android:name="android.intent.category.LAUNCHER" />
		</intent-filter>
		</activity>

		<activity
		android:name="AlphaLayersActivity"
		android:label="_αLayers">

tests/HwAccelerationTest/res/layout/view_layers_4.xml

0 → 100644

+48 −0

Original line number	Diff line number	Diff line
		<?xml version="1.0" encoding="utf-8"?>
		<!-- Copyright (C) 2011 The Android Open Source Project

		Licensed under the Apache License, Version 2.0 (the "License");
		you may not use this file except in compliance with the License.
		You may obtain a copy of the License at

		http://www.apache.org/licenses/LICENSE-2.0

		Unless required by applicable law or agreed to in writing, software
		distributed under the License is distributed on an "AS IS" BASIS,
		WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		See the License for the specific language governing permissions and
		limitations under the License.
		-->

		<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
		android:orientation="horizontal"
		android:layout_width="match_parent"
		android:layout_height="match_parent">

		<LinearLayout
		android:orientation="vertical"
		android:layout_width="0dip"
		android:layout_height="match_parent"
		android:layout_weight="1">

		<Button
		android:onClick="setListTranslucent"
		android:layout_width="wrap_content"
		android:layout_height="wrap_content"
		android:text="Set translucent" />

		<Button
		android:onClick="setListOpaque"
		android:layout_width="wrap_content"
		android:layout_height="wrap_content"
		android:text="Set opaque" />

		</LinearLayout>

		<ListView
		android:id="@+id/list1"
		android:layout_width="0dip"
		android:layout_height="match_parent"
		android:layout_weight="1" />

		</LinearLayout>

tests/HwAccelerationTest/src/com/android/test/hwui/ViewLayersActivity4.java

0 → 100644

+115 −0

Original line number	Diff line number	Diff line
		/*
		* Copyright (C) 2011 The Android Open Source Project
		*
		* Licensed under the Apache License, Version 2.0 (the "License");
		* you may not use this file except in compliance with the License.
		* You may obtain a copy of the License at
		*
		* http://www.apache.org/licenses/LICENSE-2.0
		*
		* Unless required by applicable law or agreed to in writing, software
		* distributed under the License is distributed on an "AS IS" BASIS,
		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		* See the License for the specific language governing permissions and
		* limitations under the License.
		*/

		package com.android.test.hwui;

		import android.app.Activity;
		import android.content.Context;
		import android.content.res.Resources;
		import android.os.Bundle;
		import android.util.DisplayMetrics;
		import android.view.View;
		import android.view.ViewGroup;
		import android.widget.ArrayAdapter;
		import android.widget.ListView;
		import android.widget.TextView;

		@SuppressWarnings({"UnusedDeclaration"})
		public class ViewLayersActivity4 extends Activity {
		@Override
		protected void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);

		setContentView(R.layout.view_layers_4);

		setupList(R.id.list1);
		}

		public void setListTranslucent(View v) {
		findViewById(R.id.list1).setAlpha(0.5f);
		}

		public void setListOpaque(View v) {
		findViewById(R.id.list1).setAlpha(1.0f);
		}

		private void setupList(int listId) {
		final ListView list = (ListView) findViewById(listId);
		list.setAdapter(new SimpleListAdapter(this));
		list.setLayerType(View.LAYER_TYPE_HARDWARE, null);
		}

		private static class SimpleListAdapter extends ArrayAdapter<String> {
		public SimpleListAdapter(Context context) {
		super(context, android.R.layout.simple_list_item_1, DATA_LIST);
		}

		@Override
		public View getView(int position, View convertView, ViewGroup parent) {
		TextView v = (TextView) super.getView(position, convertView, parent);
		final Resources r = getContext().getResources();
		final DisplayMetrics metrics = r.getDisplayMetrics();
		v.setCompoundDrawablePadding((int) (6 * metrics.density + 0.5f));
		v.setCompoundDrawablesWithIntrinsicBounds(r.getDrawable(R.drawable.icon),
		null, null, null);
		return v;
		}
		}

		private static final String[] DATA_LIST = {
		"Afghanistan", "Albania", "Algeria", "American Samoa", "Andorra",
		"Angola", "Anguilla", "Antarctica", "Antigua and Barbuda", "Argentina",
		"Armenia", "Aruba", "Australia", "Austria", "Azerbaijan",
		"Bahrain", "Bangladesh", "Barbados", "Belarus", "Belgium",
		"Belize", "Benin", "Bermuda", "Bhutan", "Bolivia",
		"Bosnia and Herzegovina", "Botswana", "Bouvet Island", "Brazil",
		"British Indian Ocean Territory", "British Virgin Islands", "Brunei", "Bulgaria",
		"Burkina Faso", "Burundi", "Cote d'Ivoire", "Cambodia", "Cameroon", "Canada", "Cape Verde",
		"Cayman Islands", "Central African Republic", "Chad", "Chile", "China",
		"Christmas Island", "Cocos (Keeling) Islands", "Colombia", "Comoros", "Congo",
		"Cook Islands", "Costa Rica", "Croatia", "Cuba", "Cyprus", "Czech Republic",
		"Democratic Republic of the Congo", "Denmark", "Djibouti", "Dominica", "Dominican Republic",
		"East Timor", "Ecuador", "Egypt", "El Salvador", "Equatorial Guinea", "Eritrea",
		"Estonia", "Ethiopia", "Faeroe Islands", "Falkland Islands", "Fiji", "Finland",
		"Former Yugoslav Republic of Macedonia", "France", "French Guiana", "French Polynesia",
		"French Southern Territories", "Gabon", "Georgia", "Germany", "Ghana", "Gibraltar",
		"Greece", "Greenland", "Grenada", "Guadeloupe", "Guam", "Guatemala", "Guinea", "Guinea-Bissau",
		"Guyana", "Haiti", "Heard Island and McDonald Islands", "Honduras", "Hong Kong", "Hungary",
		"Iceland", "India", "Indonesia", "Iran", "Iraq", "Ireland", "Israel", "Italy", "Jamaica",
		"Japan", "Jordan", "Kazakhstan", "Kenya", "Kiribati", "Kuwait", "Kyrgyzstan", "Laos",
		"Latvia", "Lebanon", "Lesotho", "Liberia", "Libya", "Liechtenstein", "Lithuania", "Luxembourg",
		"Macau", "Madagascar", "Malawi", "Malaysia", "Maldives", "Mali", "Malta", "Marshall Islands",
		"Martinique", "Mauritania", "Mauritius", "Mayotte", "Mexico", "Micronesia", "Moldova",
		"Monaco", "Mongolia", "Montserrat", "Morocco", "Mozambique", "Myanmar", "Namibia",
		"Nauru", "Nepal", "Netherlands", "Netherlands Antilles", "New Caledonia", "New Zealand",
		"Nicaragua", "Niger", "Nigeria", "Niue", "Norfolk Island", "North Korea", "Northern Marianas",
		"Norway", "Oman", "Pakistan", "Palau", "Panama", "Papua New Guinea", "Paraguay", "Peru",
		"Philippines", "Pitcairn Islands", "Poland", "Portugal", "Puerto Rico", "Qatar",
		"Reunion", "Romania", "Russia", "Rwanda", "Sqo Tome and Principe", "Saint Helena",
		"Saint Kitts and Nevis", "Saint Lucia", "Saint Pierre and Miquelon",
		"Saint Vincent and the Grenadines", "Samoa", "San Marino", "Saudi Arabia", "Senegal",
		"Seychelles", "Sierra Leone", "Singapore", "Slovakia", "Slovenia", "Solomon Islands",
		"Somalia", "South Africa", "South Georgia and the South Sandwich Islands", "South Korea",
		"Spain", "Sri Lanka", "Sudan", "Suriname", "Svalbard and Jan Mayen", "Swaziland", "Sweden",
		"Switzerland", "Syria", "Taiwan", "Tajikistan", "Tanzania", "Thailand", "The Bahamas",
		"The Gambia", "Togo", "Tokelau", "Tonga", "Trinidad and Tobago", "Tunisia", "Turkey",
		"Turkmenistan", "Turks and Caicos Islands", "Tuvalu", "Virgin Islands", "Uganda",
		"Ukraine", "United Arab Emirates", "United Kingdom",
		"United States", "United States Minor Outlying Islands", "Uruguay", "Uzbekistan",
		"Vanuatu", "Vatican City", "Venezuela", "Vietnam", "Wallis and Futuna", "Western Sahara",
		"Yemen", "Yugoslavia", "Zambia", "Zimbabwe"
		};
		}