Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53fdbbcc authored by Alex Johnston's avatar Alex Johnston
Browse files

DPMS setProfileOwner access control 

* Check whether the caller is system or has
  permission to set the profile owner before
  checking whether the package exists on
  device.

Manual testing
* Call DPMS setProfileOwner with an installed
  package but not as the system caller
* Call DPMS setProfileOwner with an uninstalled
  package and not as the system caller
* Both calls should give the same error message
  and logs.

Bug: 184525740
Test: manual testing
      atest com.android.server.devicepolicy.DevicePolicyManagerTest
      atest com.android.cts.devicepolicy.ProfileOwnerTest
Change-Id: I24e4d33442b0cf9baae290c0dbde45d725843055
parent 60f71b5b

services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java

+5 −9
Original line number Diff line number Diff line
@@ -8517,20 +8517,16 @@ public class DevicePolicyManagerService extends BaseIDevicePolicyManager { 
                    + " as profile owner for user " + userHandle);

            return false;

        }

        if (who == null

                || !isPackageInstalledForUser(who.getPackageName(), userHandle)) {

            throw new IllegalArgumentException("Component " + who

                    + " not installed for userId:" + userHandle);

        }

        Preconditions.checkArgument(who != null);















        final CallerIdentity caller = getCallerIdentity();















        synchronized (getLockObject()) {















            enforceCanSetProfileOwnerLocked(caller, who, userHandle);

























            Preconditions.checkArgument(isPackageInstalledForUser(who.getPackageName(), userHandle),













                    "Component " + who + " not installed for userId:" + userHandle);















            final ActiveAdmin admin = getActiveAdminUncheckedLocked(who, userHandle);













            if (admin == null || getUserData(userHandle).mRemovingAdmins.contains(who)) {













                throw new IllegalArgumentException("Not active admin: " + who);













            }













            Preconditions.checkArgument(admin != null && !getUserData(













                    userHandle).mRemovingAdmins.contains(who), "Not active admin: " + who);





























            final int parentUserId = getProfileParentId(userHandle);















            // When trying to set a profile owner on a new user, it may be that this user is

































services/tests/servicestests/src/com/android/server/devicepolicy/DevicePolicyManagerTest.java



+10
−0




























Original line number
Diff line number
Diff line








@@ -1551,6 +1551,16 @@ public class DevicePolicyManagerTest extends DpmTestBase {













    @Test















    public void testSetProfileOwner_failures() throws Exception {















        // TODO Test more failure cases.  Basically test all chacks in enforceCanSetProfileOwner().













        // Package doesn't exist and caller is not system













        assertExpectException(SecurityException.class,













                /* messageRegex= */ "Calling identity is not authorized",













                () -> dpm.setProfileOwner(admin1, "owner-name", UserHandle.USER_SYSTEM));



























        // Package exists, but caller is not system













        setUpPackageManagerForAdmin(admin1, DpmMockContext.CALLER_SYSTEM_USER_UID);













        assertExpectException(SecurityException.class,













                /* messageRegex= */ "Calling identity is not authorized",













                () -> dpm.setProfileOwner(admin1, "owner-name", UserHandle.USER_SYSTEM));















    }































    @Test