Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53aa5744 authored by Youngsang Cho's avatar Youngsang Cho
Browse files

Make TvInputService skip to dispatch media keys to an overlay view 

If media keys are dispatched to an overlay view, it is always consumed
because of fallback logic. Therefore, TvInputService skips to dispatch
media keys to an overlay view in order to return the keys back to
an application.

Bug: 18195249
Change-Id: I1cb4c9de5a73bd741ab64b1b85e9c986a1a92a90
parent 727899fd

media/java/android/media/tv/TvInputService.java

+10 −2
Original line number Diff line number Diff line
@@ -1076,12 +1076,19 @@ public abstract class TvInputService extends Service { 
        int dispatchInputEvent(InputEvent event, InputEventReceiver receiver) {

            if (DEBUG) Log.d(TAG, "dispatchInputEvent(" + event + ")");

            boolean isNavigationKey = false;

            boolean skipDispatchToOverlayView = false;

            if (event instanceof KeyEvent) {

                KeyEvent keyEvent = (KeyEvent) event;

                isNavigationKey = isNavigationKey(keyEvent.getKeyCode());

                if (keyEvent.dispatch(this, mDispatcherState, this)) {

                    return TvInputManager.Session.DISPATCH_HANDLED;

                }

                isNavigationKey = isNavigationKey(keyEvent.getKeyCode());

                // When media keys and KEYCODE_MEDIA_AUDIO_TRACK are dispatched to ViewRootImpl,

                // ViewRootImpl always consumes the keys. In this case, an application loses

                // a chance to handle media keys. Therefore, media keys are not dispatched to

                // ViewRootImpl.

                skipDispatchToOverlayView = KeyEvent.isMediaKey(keyEvent.getKeyCode())

                        || keyEvent.getKeyCode() == KeyEvent.KEYCODE_MEDIA_AUDIO_TRACK;

            } else if (event instanceof MotionEvent) {

                MotionEvent motionEvent = (MotionEvent) event;

                final int source = motionEvent.getSource();
@@ -1099,7 +1106,8 @@ public abstract class TvInputService extends Service { 
                    }

                }

            }

            if (mOverlayViewContainer == null || !mOverlayViewContainer.isAttachedToWindow()) {

            if (mOverlayViewContainer == null || !mOverlayViewContainer.isAttachedToWindow()

                    || skipDispatchToOverlayView) {

                return TvInputManager.Session.DISPATCH_NOT_HANDLED;

            }

            if (!mOverlayViewContainer.hasWindowFocus()) {