Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 530dd76f authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove IInputMethodSession#finishInput(), which is called nowhere 

Currently IInputMethodSession#finishInput() is called nowhere.

Let's remove this IPC method exposed from InputMethodService to IME
client for now until we fully understand what is the right approach on
how and when InputMethodService#finishInput() should be called.

Note that we cannot simply remove InputMethodSession#finishInput()
because it is already published as a public API.  In Bug 9216494
hopefully we can also discuss whether InputMethodSession#finishInput()
should be deprecated or can be reused for some actual use cases.

Bug: 9216494
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: I9e378111c9df40cb6821583d1e6ae8f9fe38f2b1
parent f7517f15

core/java/android/inputmethodservice/IInputMethodSessionWrapper.java

+1 −10
Original line number Diff line number Diff line
@@ -42,7 +42,6 @@ class IInputMethodSessionWrapper extends IInputMethodSession.Stub 
        implements HandlerCaller.Callback {

    private static final String TAG = "InputMethodWrapper";



    private static final int DO_FINISH_INPUT = 60;

    private static final int DO_DISPLAY_COMPLETIONS = 65;

    private static final int DO_UPDATE_EXTRACTED_TEXT = 67;

    private static final int DO_UPDATE_SELECTION = 90;
@@ -89,9 +88,6 @@ class IInputMethodSessionWrapper extends IInputMethodSession.Stub 
        }



        switch (msg.what) {

            case DO_FINISH_INPUT:

                mInputMethodSession.finishInput();

                return;

            case DO_DISPLAY_COMPLETIONS:

                mInputMethodSession.displayCompletions((CompletionInfo[])msg.obj);

                return;
@@ -149,11 +145,6 @@ class IInputMethodSessionWrapper extends IInputMethodSession.Stub 
        }

    }



    @Override

    public void finishInput() {

        mCaller.executeOrSendMessage(mCaller.obtainMessage(DO_FINISH_INPUT));

    }



    @Override

    public void displayCompletions(CompletionInfo[] completions) {

        mCaller.executeOrSendMessage(mCaller.obtainMessageO(

core/java/com/android/internal/view/IInputMethodSession.aidl

+1 −3
Original line number Diff line number Diff line
@@ -29,8 +29,6 @@ import android.view.inputmethod.ExtractedText; 
 * {@hide}

 */

oneway interface IInputMethodSession {

    void finishInput();



    void updateExtractedText(int token, in ExtractedText text);



    void updateSelection(int oldSelStart, int oldSelEnd,