Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52426e3c authored by Achim Thesmann's avatar Achim Thesmann
Browse files

Return BAL Verdict with logging information 

Instead of logging in multiple places (including multiple times and
writing stats multiple times) return the result code
combined with meta information to be logged (and metricked) more
central.

Test: atest BackgroundActivityLaunchTest
Bug: 306059525
Change-Id: Iafd785353452ff62301a13d0816c0c035b0940cd
parent 80697da8

services/core/java/com/android/server/wm/ActivityStarter.java

+15 −16
Original line number Diff line number Diff line
@@ -1097,7 +1097,7 @@ class ActivityStarter { 
                        "shouldAbortBackgroundActivityStart");

                BackgroundActivityStartController balController =

                        mSupervisor.getBackgroundActivityLaunchController();

                balCode =

                BackgroundActivityStartController.BalVerdict balVerdict =

                        balController.checkBackgroundActivityStart(

                            callingUid,

                            callingPid,
@@ -1109,11 +1109,10 @@ class ActivityStarter { 
                            request.backgroundStartPrivileges,

                            intent,

                            checkedOptions);

                if (balCode != BAL_ALLOW_DEFAULT) {

                balCode = balVerdict.getCode();

                request.logMessage.append(" (").append(

                                BackgroundActivityStartController.balCodeToString(balCode))

                        .append(")");

                }

            } finally {

                Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

            }

services/core/java/com/android/server/wm/BackgroundActivityStartController.java

+139 −111

File changed.

Preview size limit exceeded, changes collapsed.

services/core/java/com/android/server/wm/BackgroundLaunchProcessController.java

+15 −20

File changed.

Preview size limit exceeded, changes collapsed.

services/core/java/com/android/server/wm/WindowProcessController.java

+12 −12

File changed.

Preview size limit exceeded, changes collapsed.