Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 518bc8ac authored by Ching-Sung Li's avatar Ching-Sung Li
Browse files

Save one notifyColorListeners() call 

Do color extraction if needed then notify color listeners once.

Bug: 191628465
Test: Build pass and then manually test
Change-Id: Ief9c86f4c55377c78ce2550d3cbaa2af68ff03d5
parent 5f980cbd

services/core/java/com/android/server/wallpaper/WallpaperManagerService.java

+1 −11
Original line number Diff line number Diff line
@@ -405,21 +405,11 @@ public class WallpaperManagerService extends IWallpaperManager.Stub 
            needsExtraction = wallpaper.primaryColors == null;

        }



        // Let's notify the current values, it's fine if it's null, it just means

        // that we don't know yet.

        notifyColorListeners(wallpaper.primaryColors, which, wallpaper.userId, displayId);



        if (needsExtraction) {

            extractColors(wallpaper);

            synchronized (mLock) {

                // Don't need to notify if nothing changed.

                if (wallpaper.primaryColors == null) {

                    return;

                }

        }

        notifyColorListeners(wallpaper.primaryColors, which, wallpaper.userId, displayId);

    }

    }



    private static <T extends IInterface> boolean emptyCallbackList(RemoteCallbackList<T> list) {

        return (list == null || list.getRegisteredCallbackCount() == 0);