Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51586d5e authored by Cheonho Park's avatar Cheonho Park
Browse files

Allow signing key rotation 

Support GET_SIGNING_CERTIFICATES and handle certificates at SigningInfo

Bug: 138416125
Test: Manual with USIM ARA-M and Test app signed with key rotation
Change-Id: Ie6a32e93b248dab502ea71d54e4bfa84ee1e01e2
parent 29899487

telephony/java/android/telephony/SubscriptionInfo.java

+2 −1
Original line number Diff line number Diff line
@@ -572,7 +572,8 @@ public class SubscriptionInfo implements Parcelable { 
        PackageManager packageManager = context.getPackageManager();

        PackageInfo packageInfo;

        try {

            packageInfo = packageManager.getPackageInfo(packageName, PackageManager.GET_SIGNATURES);

            packageInfo = packageManager.getPackageInfo(packageName,

                PackageManager.GET_SIGNING_CERTIFICATES);

        } catch (PackageManager.NameNotFoundException e) {

            throw new IllegalArgumentException("Unknown package: " + packageName, e);

        }

telephony/java/android/telephony/SubscriptionManager.java

+2 −1
Original line number Diff line number Diff line
@@ -2607,7 +2607,8 @@ public class SubscriptionManager { 
        PackageManager packageManager = mContext.getPackageManager();

        PackageInfo packageInfo;

        try {

            packageInfo = packageManager.getPackageInfo(packageName, PackageManager.GET_SIGNATURES);

            packageInfo = packageManager.getPackageInfo(packageName,

                PackageManager.GET_SIGNING_CERTIFICATES);

        } catch (PackageManager.NameNotFoundException e) {

            throw new IllegalArgumentException("Unknown package: " + packageName, e);

        }

telephony/java/android/telephony/UiccAccessRule.java

+16 −4
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ import android.annotation.Nullable; 
import android.annotation.SystemApi;

import android.content.pm.PackageInfo;

import android.content.pm.Signature;

import android.content.pm.SigningInfo;

import android.os.Parcel;

import android.os.Parcelable;

import android.text.TextUtils;
@@ -168,17 +169,28 @@ public final class UiccAccessRule implements Parcelable { 
     *

     * @param packageInfo package info fetched from

     *     {@link android.content.pm.PackageManager#getPackageInfo}.

     *     {@link android.content.pm.PackageManager#GET_SIGNATURES} must have been passed in.

     *     {@link android.content.pm.PackageManager#GET_SIGNING_CERTIFICATES} must have been

     *         passed in.

     * @return either {@link TelephonyManager#CARRIER_PRIVILEGE_STATUS_HAS_ACCESS} or

     *     {@link TelephonyManager#CARRIER_PRIVILEGE_STATUS_NO_ACCESS}.

     */

    public int getCarrierPrivilegeStatus(PackageInfo packageInfo) {

        if (packageInfo.signatures == null || packageInfo.signatures.length == 0) {

        Signature[] signatures = packageInfo.signatures;

        SigningInfo sInfo = packageInfo.signingInfo;



        if (sInfo != null) {

            signatures = sInfo.getSigningCertificateHistory();

            if (sInfo.hasMultipleSigners()) {

                signatures = sInfo.getApkContentsSigners();

            }

        }



        if (signatures == null || signatures.length == 0) {

            throw new IllegalArgumentException(

                    "Must use GET_SIGNATURES when looking up package info");

                    "Must use GET_SIGNING_CERTIFICATES when looking up package info");

        }



        for (Signature sig : packageInfo.signatures) {

        for (Signature sig : signatures) {

            int accessStatus = getCarrierPrivilegeStatus(sig, packageInfo.packageName);

            if (accessStatus != TelephonyManager.CARRIER_PRIVILEGE_STATUS_NO_ACCESS) {

                return accessStatus;