Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 510212b3 authored by Caitlin Cassidy's avatar Caitlin Cassidy
Browse files

[View Controllers] Move more KeyguardStatusBarView methods out of 

NotificationPanelViewController and into KSBVController.

Test: atest KeyguardStatusBarViewControllerTest
Bug: 195442899
Change-Id: I3f0d3b74651bcce2ac68a7d8a29d85cfa5a635e7
parent 1640a07a

packages/SystemUI/src/com/android/systemui/statusbar/phone/KeyguardStatusBarViewController.java

+8 −0
Original line number Diff line number Diff line
@@ -205,6 +205,14 @@ public class KeyguardStatusBarViewController extends ViewController<KeyguardStat 
        mView.setTopClipping(notificationPanelTop - mView.getTop());

    }



    /**

     * Updates the {@link KeyguardStatusBarView} state based on the provided values.

     */

    public void updateViewState(float alpha, int visibility) {

        mView.setAlpha(alpha);

        mView.setVisibility(visibility);

    }



    /** */

    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        pw.println("KeyguardStatusBarView:");

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java

+3 −2
Original line number Diff line number Diff line
@@ -4494,8 +4494,9 @@ public class NotificationPanelViewController extends PanelViewController { 
                    }

                }

            } else {

                mKeyguardStatusBar.setAlpha(1f);

                mKeyguardStatusBar.setVisibility(keyguardShowing ? View.VISIBLE : View.INVISIBLE);

                mKeyguardStatusBarViewController.updateViewState(

                        /* alpha= */ 1f,

                        keyguardShowing ? View.VISIBLE : View.INVISIBLE);

                if (keyguardShowing && oldState != mBarState) {

                    if (mQs != null) {

                        mQs.hideImmediately();

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardStatusBarViewControllerTest.java

+15 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ import static org.mockito.Mockito.verify; 
import android.testing.AndroidTestingRunner;

import android.testing.TestableLooper;

import android.view.LayoutInflater;

import android.view.View;



import androidx.test.filters.SmallTest;
@@ -162,4 +163,18 @@ public class KeyguardStatusBarViewControllerTest extends SysuiTestCase { 


        assertThat(mKeyguardStatusBarView.getClipBounds().top).isEqualTo(0);

    }



    @Test

    public void updateViewState_alphaAndVisibilityGiven_viewUpdated() {

        // Verify the initial values so we know the method triggers changes.

        assertThat(mKeyguardStatusBarView.getAlpha()).isEqualTo(1f);

        assertThat(mKeyguardStatusBarView.getVisibility()).isEqualTo(View.VISIBLE);



        float newAlpha = 0.5f;

        int newVisibility = View.INVISIBLE;

        mController.updateViewState(newAlpha, newVisibility);



        assertThat(mKeyguardStatusBarView.getAlpha()).isEqualTo(newAlpha);

        assertThat(mKeyguardStatusBarView.getVisibility()).isEqualTo(newVisibility);

    }

}