Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50271cd7 authored by TYM Tsai's avatar TYM Tsai Committed by Automerger Merge Worker
Browse files

Merge "API feedback: Modify javadoc for showAutofillDialog" into tm-dev am: 12354226 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17315583

Change-Id: Id8215a064be43c8987c234fa3b3b452a221c49ec
Signed-off-by: Automerger Merge Worker
parents fb6b8b64 12354226

core/java/android/view/autofill/AutofillManager.java

+18 −3
Original line number Diff line number Diff line
@@ -3152,11 +3152,26 @@ public final class AutofillManager { 
    }



    /**

     * Like {@link #showAutofillDialog(View)} but for virtual views.

     * If autofill suggestions for a

     * <a href="{@docRoot}reference/android/service/autofill/Dataset.html#FillDialogUI">

     * dialog-style UI</a> are available for virtual {@code view}, shows a dialog allowing the user

     * to select a suggestion and returns {@code true}.

     * <p>

     * The dialog may not be shown if the autofill service does not support it, if the autofill

     * request has not returned a response yet, if the dialog was shown previously, or if the

     * input method is already shown.

     * <p>

     * It is recommended apps to call this method the first time a user focuses on

     * an autofill-able form, and to avoid showing the input method if the dialog is shown. If

     * this method returns {@code false}, you should then instead show the input method (assuming

     * that is how the view normally handles the focus event). If the user re-focuses on the view,

     * you should not call this method again so as to not disrupt usage of the input method.

     *

     * @param virtualId id identifying the virtual child inside the parent view.

     * @param view the view hosting the virtual view hierarchy which is used to show autofill

     *            suggestions.

     * @param virtualId id identifying the virtual view inside the host view.

     * @return {@code true} if the autofill dialog is being shown

     */

    // TODO(b/210926084): Consider whether to include the one-time show logic within this method.

    public boolean showAutofillDialog(@NonNull View view, int virtualId) {

        Objects.requireNonNull(view);

        if (shouldShowAutofillDialog(getAutofillId(view, virtualId))) {