Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fe73353 authored by Jeremy Sim's avatar Jeremy Sim Committed by Vinit Nayak
Browse files

When resizing split and both sides are veiled, make sure both sides are veiled with the same color 

This is a temporary quick fix for b/339274381. When a split resize is initiated and both sides are being veiled (like when Chrome is opening a new instance of itself), there is a bug where the two sides return different colors, which looks bad. This patch ensures that both sides are veiled with the same color.

When b/339274381 is fixed, this CL can be reverted entirely.

Bug: 307490004
Test: Launch an adjacent task from Chrome using the repro steps in b/339274381, see that both sides are the same color.
Flag: None
Change-Id: I3158a1da29ec58c5412401b67a6905c31bb120b1
Merged-In: I3158a1da29ec58c5412401b67a6905c31bb120b1
parent d298effd

libs/WindowManager/Shell/src/com/android/wm/shell/common/split/SplitDecorManager.java

+3 −9
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ import android.animation.ValueAnimator; 
import android.app.ActivityManager;

import android.content.Context;

import android.content.res.Configuration;

import android.graphics.Color;

import android.graphics.PixelFormat;

import android.graphics.Rect;

import android.graphics.drawable.Drawable;
@@ -202,7 +201,7 @@ public class SplitDecorManager extends WindowlessWindowManager { 
    /** Showing resizing hint. */

    public void onResizing(ActivityManager.RunningTaskInfo resizingTask, Rect newBounds,

            Rect sideBounds, SurfaceControl.Transaction t, int offsetX, int offsetY,

            boolean immediately) {

            boolean immediately, float[] veilColor) {

        if (mResizingIconView == null) {

            return;

        }
@@ -235,7 +234,7 @@ public class SplitDecorManager extends WindowlessWindowManager { 
        if (mBackgroundLeash == null) {

            mBackgroundLeash = SurfaceUtils.makeColorLayer(mHostLeash,

                    RESIZING_BACKGROUND_SURFACE_NAME, mSurfaceSession);

            t.setColor(mBackgroundLeash, getResizingBackgroundColor(resizingTask))

            t.setColor(mBackgroundLeash, veilColor)

                    .setLayer(mBackgroundLeash, Integer.MAX_VALUE - 1);

        }
@@ -246,7 +245,7 @@ public class SplitDecorManager extends WindowlessWindowManager { 
            mGapBackgroundLeash = SurfaceUtils.makeColorLayer(mHostLeash,

                    GAP_BACKGROUND_SURFACE_NAME, mSurfaceSession);

            // Fill up another side bounds area.

            t.setColor(mGapBackgroundLeash, getResizingBackgroundColor(resizingTask))

            t.setColor(mGapBackgroundLeash, veilColor)

                    .setLayer(mGapBackgroundLeash, Integer.MAX_VALUE - 2)

                    .setPosition(mGapBackgroundLeash, left, top)

                    .setWindowCrop(mGapBackgroundLeash, sideBounds.width(), sideBounds.height());
@@ -485,9 +484,4 @@ public class SplitDecorManager extends WindowlessWindowManager { 
            mIcon = null;

        }

    }



    private static float[] getResizingBackgroundColor(ActivityManager.RunningTaskInfo taskInfo) {

        final int taskBgColor = taskInfo.taskDescription.getBackgroundColor();

        return Color.valueOf(taskBgColor == -1 ? Color.WHITE : taskBgColor).getComponents();

    }

}

libs/WindowManager/Shell/src/com/android/wm/shell/common/split/SplitScreenUtils.java

+7 −10
Original line number Diff line number Diff line
@@ -16,8 +16,6 @@ 


package com.android.wm.shell.common.split;



import static android.content.pm.LauncherApps.ShortcutQuery.FLAG_MATCH_ALL_KINDS_WITH_ALL_PINNED;



import static com.android.wm.shell.common.split.SplitScreenConstants.CONTROLLED_ACTIVITY_TYPES;

import static com.android.wm.shell.common.split.SplitScreenConstants.CONTROLLED_WINDOWING_MODES;

import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSITION_BOTTOM_OR_RIGHT;
@@ -26,25 +24,18 @@ import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSIT 


import android.app.ActivityManager;

import android.app.PendingIntent;

import android.content.ComponentName;

import android.content.Intent;

import android.content.pm.LauncherApps;

import android.content.pm.ShortcutInfo;

import android.content.res.Configuration;

import android.content.res.Resources;

import android.graphics.Color;

import android.graphics.Rect;

import android.os.UserHandle;



import androidx.annotation.NonNull;

import androidx.annotation.Nullable;



import com.android.internal.util.ArrayUtils;

import com.android.wm.shell.Flags;

import com.android.wm.shell.ShellTaskOrganizer;



import java.util.Arrays;

import java.util.List;



/** Helper utility class for split screen components to use. */

public class SplitScreenUtils {

    /** Reverse the split position. */
@@ -137,4 +128,10 @@ public class SplitScreenUtils { 
            return isLandscape;

        }

    }



    /** Returns the specified background color that matches a RunningTaskInfo. */

    public static Color getResizingBackgroundColor(ActivityManager.RunningTaskInfo taskInfo) {

        final int taskBgColor = taskInfo.taskDescription.getBackgroundColor();

        return Color.valueOf(taskBgColor == -1 ? Color.WHITE : taskBgColor);

    }

}

libs/WindowManager/Shell/src/com/android/wm/shell/draganddrop/DragLayout.java

+4 −10
Original line number Diff line number Diff line
@@ -22,11 +22,11 @@ import static android.content.pm.ActivityInfo.CONFIG_ASSETS_PATHS; 
import static android.content.pm.ActivityInfo.CONFIG_UI_MODE;

import static android.content.res.Configuration.ORIENTATION_LANDSCAPE;

import static android.view.ViewGroup.LayoutParams.MATCH_PARENT;

import static android.view.ViewTreeObserver.InternalInsetsInfo.TOUCHABLE_INSETS_FRAME;

import static android.view.ViewTreeObserver.InternalInsetsInfo.TOUCHABLE_INSETS_REGION;



import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSITION_BOTTOM_OR_RIGHT;

import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSITION_TOP_OR_LEFT;

import static com.android.wm.shell.common.split.SplitScreenUtils.getResizingBackgroundColor;

import static com.android.wm.shell.draganddrop.DragAndDropPolicy.Target.TYPE_SPLIT_BOTTOM;

import static com.android.wm.shell.draganddrop.DragAndDropPolicy.Target.TYPE_SPLIT_LEFT;

import static com.android.wm.shell.draganddrop.DragAndDropPolicy.Target.TYPE_SPLIT_RIGHT;
@@ -41,7 +41,6 @@ import android.app.StatusBarManager; 
import android.content.Context;

import android.content.res.Configuration;

import android.content.res.Resources;

import android.graphics.Color;

import android.graphics.Insets;

import android.graphics.Rect;

import android.graphics.Region;
@@ -278,7 +277,7 @@ public class DragLayout extends LinearLayout 
                final int activityType = taskInfo1.getActivityType();

                if (activityType == ACTIVITY_TYPE_STANDARD) {

                    Drawable icon1 = mIconProvider.getIcon(taskInfo1.topActivityInfo);

                    int bgColor1 = getResizingBackgroundColor(taskInfo1);

                    int bgColor1 = getResizingBackgroundColor(taskInfo1).toArgb();

                    mDropZoneView1.setAppInfo(bgColor1, icon1);

                    mDropZoneView2.setAppInfo(bgColor1, icon1);

                    updateDropZoneSizes(null, null); // passing null splits the views evenly
@@ -298,10 +297,10 @@ public class DragLayout extends LinearLayout 
                    mSplitScreenController.getTaskInfo(SPLIT_POSITION_BOTTOM_OR_RIGHT);

            if (topOrLeftTask != null && bottomOrRightTask != null) {

                Drawable topOrLeftIcon = mIconProvider.getIcon(topOrLeftTask.topActivityInfo);

                int topOrLeftColor = getResizingBackgroundColor(topOrLeftTask);

                int topOrLeftColor = getResizingBackgroundColor(topOrLeftTask).toArgb();

                Drawable bottomOrRightIcon = mIconProvider.getIcon(

                        bottomOrRightTask.topActivityInfo);

                int bottomOrRightColor = getResizingBackgroundColor(bottomOrRightTask);

                int bottomOrRightColor = getResizingBackgroundColor(bottomOrRightTask).toArgb();

                mDropZoneView1.setAppInfo(topOrLeftColor, topOrLeftIcon);

                mDropZoneView2.setAppInfo(bottomOrRightColor, bottomOrRightIcon);

            }
@@ -556,11 +555,6 @@ public class DragLayout extends LinearLayout 
        }

    }



    private static int getResizingBackgroundColor(ActivityManager.RunningTaskInfo taskInfo) {

        final int taskBgColor = taskInfo.taskDescription.getBackgroundColor();

        return Color.valueOf(taskBgColor == -1 ? Color.WHITE : taskBgColor).toArgb();

    }



    /**

     * Dumps information about this drag layout.

     */

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/StageCoordinator.java

+8 −2
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSIT 
import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSITION_TOP_OR_LEFT;

import static com.android.wm.shell.common.split.SplitScreenConstants.SPLIT_POSITION_UNDEFINED;

import static com.android.wm.shell.common.split.SplitScreenConstants.splitPositionToString;

import static com.android.wm.shell.common.split.SplitScreenUtils.getResizingBackgroundColor;

import static com.android.wm.shell.common.split.SplitScreenUtils.reverseSplitPosition;

import static com.android.wm.shell.common.split.SplitScreenUtils.splitFailureMessage;

import static com.android.wm.shell.protolog.ShellProtoLogGroup.WM_SHELL_SPLIT_SCREEN;
@@ -2359,8 +2360,13 @@ public class StageCoordinator implements SplitLayout.SplitLayoutHandler, 
        updateSurfaceBounds(layout, t, shouldUseParallaxEffect);

        getMainStageBounds(mTempRect1);

        getSideStageBounds(mTempRect2);

        mMainStage.onResizing(mTempRect1, mTempRect2, t, offsetX, offsetY, mShowDecorImmediately);

        mSideStage.onResizing(mTempRect2, mTempRect1, t, offsetX, offsetY, mShowDecorImmediately);

        // TODO (b/307490004): "commonColor" below is a temporary fix to ensure the colors on both

        //  sides match. When b/307490004 is fixed, this code can be reverted.

        float[] commonColor = getResizingBackgroundColor(mSideStage.mRootTaskInfo).getComponents();

        mMainStage.onResizing(

                mTempRect1, mTempRect2, t, offsetX, offsetY, mShowDecorImmediately, commonColor);

        mSideStage.onResizing(

                mTempRect2, mTempRect1, t, offsetX, offsetY, mShowDecorImmediately, commonColor);

        t.apply();

        mTransactionPool.release(t);

    }

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/StageTaskListener.java

+2 −2
Original line number Diff line number Diff line
@@ -310,10 +310,10 @@ class StageTaskListener implements ShellTaskOrganizer.TaskListener { 
    }



    void onResizing(Rect newBounds, Rect sideBounds, SurfaceControl.Transaction t, int offsetX,

            int offsetY, boolean immediately) {

            int offsetY, boolean immediately, float[] veilColor) {

        if (mSplitDecorManager != null && mRootTaskInfo != null) {

            mSplitDecorManager.onResizing(mRootTaskInfo, newBounds, sideBounds, t, offsetX,

                    offsetY, immediately);

                    offsetY, immediately, veilColor);

        }

    }