Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fb6d541 authored by Steve Elliott's avatar Steve Elliott Committed by Android (Google) Code Review
Browse files

Merge changes from topic "shelf-refactor-flag" into udc-dev 

* changes:
  NotificationShelf ViewBinder + WrapperController
  Extract interface for NotificationShelfController
  Remove dead code from NotificationShelf+Controller
  Add flag for NotificationShelf refactor
parents 6630d5ff 7236cad9

packages/SystemUI/src/com/android/systemui/flags/Flags.kt

+5 −0
Original line number Diff line number Diff line
@@ -103,6 +103,11 @@ object Flags { 
    val FILTER_UNSEEN_NOTIFS_ON_KEYGUARD =

        releasedFlag(254647461, "filter_unseen_notifs_on_keyguard")



    // TODO(b/277338665): Tracking Bug

    @JvmField

    val NOTIFICATION_SHELF_REFACTOR =

        unreleasedFlag(271161129, "notification_shelf_refactor")



    // TODO(b/263414400): Tracking Bug

    @JvmField

    val NOTIFICATION_ANIMATE_BIG_PICTURE =

packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelfController.java→packages/SystemUI/src/com/android/systemui/statusbar/LegacyNotificationShelfControllerImpl.java

+9 −24
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ import com.android.systemui.statusbar.notification.row.ActivatableNotificationVi 
import com.android.systemui.statusbar.notification.row.dagger.NotificationRowScope;

import com.android.systemui.statusbar.notification.stack.AmbientState;

import com.android.systemui.statusbar.notification.stack.NotificationStackScrollLayoutController;

import com.android.systemui.statusbar.notification.stack.StackScrollAlgorithm;

import com.android.systemui.statusbar.phone.KeyguardBypassController;

import com.android.systemui.statusbar.phone.NotificationIconContainer;
@@ -35,7 +34,7 @@ import javax.inject.Inject; 
 * Controller class for {@link NotificationShelf}.

 */

@NotificationRowScope

public class NotificationShelfController {

public class LegacyNotificationShelfControllerImpl implements NotificationShelfController {

    private final NotificationShelf mView;

    private final ActivatableNotificationViewController mActivatableNotificationViewController;

    private final KeyguardBypassController mKeyguardBypassController;
@@ -44,7 +43,7 @@ public class NotificationShelfController { 
    private AmbientState mAmbientState;



    @Inject

    public NotificationShelfController(

    public LegacyNotificationShelfControllerImpl(

            NotificationShelf notificationShelf,

            ActivatableNotificationViewController activatableNotificationViewController,

            KeyguardBypassController keyguardBypassController,
@@ -79,56 +78,42 @@ public class NotificationShelfController { 
        }

    }



    @Override

    public NotificationShelf getView() {

        return mView;

    }



    @Override

    public boolean canModifyColorOfNotifications() {

        return mAmbientState.isShadeExpanded()

                && !(mAmbientState.isOnKeyguard() && mKeyguardBypassController.getBypassEnabled());

    }



    @Override

    public NotificationIconContainer getShelfIcons() {

        return mView.getShelfIcons();

    }



    public @View.Visibility int getVisibility() {

        return mView.getVisibility();

    }



    public void setCollapsedIcons(NotificationIconContainer notificationIcons) {

        mView.setCollapsedIcons(notificationIcons);

    }



    @Override

    public void bind(AmbientState ambientState,

            NotificationStackScrollLayoutController notificationStackScrollLayoutController) {

        mView.bind(ambientState, notificationStackScrollLayoutController);

        mAmbientState = ambientState;

    }



    public int getHeight() {

        return mView.getHeight();

    }



    public void updateState(StackScrollAlgorithm.StackScrollAlgorithmState algorithmState,

            AmbientState ambientState) {

        mAmbientState = ambientState;

        mView.updateState(algorithmState, ambientState);

    }



    @Override

    public int getIntrinsicHeight() {

        return mView.getIntrinsicHeight();

    }



    @Override

    public void setOnActivatedListener(ActivatableNotificationView.OnActivatedListener listener) {

        mView.setOnActivatedListener(listener);

    }



    @Override

    public void setOnClickListener(View.OnClickListener onClickListener) {

        mView.setOnClickListener(onClickListener);

    }



    public int getNotGoneIndex() {

        return mView.getNotGoneIndex();

    }

}

packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelf.java

+1 −35
Original line number Diff line number Diff line
@@ -64,8 +64,7 @@ import java.io.PrintWriter; 
 * A notification shelf view that is placed inside the notification scroller. It manages the

 * overflow icons that don't fit into the regular list anymore.

 */

public class NotificationShelf extends ActivatableNotificationView implements

        View.OnLayoutChangeListener, StateListener {

public class NotificationShelf extends ActivatableNotificationView implements StateListener {



    private static final int TAG_CONTINUOUS_CLIPPING = R.id.continuous_clipping_tag;

    private static final String TAG = "NotificationShelf";
@@ -78,7 +77,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
    private static final SourceType SHELF_SCROLL = SourceType.from("ShelfScroll");



    private NotificationIconContainer mShelfIcons;

    private int[] mTmp = new int[2];

    private boolean mHideBackground;

    private int mStatusBarHeight;

    private boolean mEnableNotificationClipping;
@@ -87,7 +85,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
    private int mPaddingBetweenElements;

    private int mNotGoneIndex;

    private boolean mHasItemsInStableShelf;

    private NotificationIconContainer mCollapsedIcons;

    private int mScrollFastThreshold;

    private int mStatusBarState;

    private boolean mInteractive;
@@ -868,10 +865,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
        return mShelfIcons.getIconState(icon);

    }



    private float getFullyClosedTranslation() {

        return -(getIntrinsicHeight() - mStatusBarHeight) / 2;

    }



    @Override

    public boolean hasNoContentHeight() {

        return true;
@@ -893,7 +886,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
    @Override

    protected void onLayout(boolean changed, int left, int top, int right, int bottom) {

        super.onLayout(changed, left, top, right, bottom);

        updateRelativeOffset();



        // we always want to clip to our sides, such that nothing can draw outside of these bounds

        int height = getResources().getDisplayMetrics().heightPixels;
@@ -903,13 +895,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
        }

    }



    private void updateRelativeOffset() {

        if (mCollapsedIcons != null) {

            mCollapsedIcons.getLocationOnScreen(mTmp);

        }

        getLocationOnScreen(mTmp);

    }



    /**

     * @return the index of the notification at which the shelf visually resides

     */
@@ -924,19 +909,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
        }

    }



    /**

     * @return whether the shelf has any icons in it when a potential animation has finished, i.e

     * if the current state would be applied right now

     */

    public boolean hasItemsInStableShelf() {

        return mHasItemsInStableShelf;

    }



    public void setCollapsedIcons(NotificationIconContainer collapsedIcons) {

        mCollapsedIcons = collapsedIcons;

        mCollapsedIcons.addOnLayoutChangeListener(this);

    }



    @Override

    public void onStateChanged(int newState) {

        mStatusBarState = newState;
@@ -982,12 +954,6 @@ public class NotificationShelf extends ActivatableNotificationView implements 
        }

    }



    @Override

    public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft,

                               int oldTop, int oldRight, int oldBottom) {

        updateRelativeOffset();

    }



    @Override

    public boolean needsClippingToShelf() {

        return false;

packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelfController.kt

0 → 100644
+54 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2023 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.systemui.statusbar



import android.view.View

import android.view.View.OnClickListener

import com.android.systemui.statusbar.notification.row.ActivatableNotificationView

import com.android.systemui.statusbar.notification.row.ActivatableNotificationView.OnActivatedListener

import com.android.systemui.statusbar.notification.row.ExpandableView

import com.android.systemui.statusbar.notification.stack.AmbientState

import com.android.systemui.statusbar.notification.stack.NotificationStackScrollLayout

import com.android.systemui.statusbar.notification.stack.NotificationStackScrollLayoutController

import com.android.systemui.statusbar.phone.NotificationIconContainer



/** Controller interface for [NotificationShelf]. */

interface NotificationShelfController {

    /** The [NotificationShelf] controlled by this Controller. */

    val view: NotificationShelf



    /** @see ExpandableView.getIntrinsicHeight */

    val intrinsicHeight: Int



    /** Container view for icons displayed in the shelf. */

    val shelfIcons: NotificationIconContainer



    /** Whether or not the shelf can modify the color of notifications in the shade. */

    fun canModifyColorOfNotifications(): Boolean



    /** @see ActivatableNotificationView.setOnActivatedListener */

    fun setOnActivatedListener(listener: OnActivatedListener)



    /** Binds the shelf to the host [NotificationStackScrollLayout], via its Controller. */

    fun bind(

        ambientState: AmbientState,

        notificationStackScrollLayoutController: NotificationStackScrollLayoutController,

    )



    /** @see View.setOnClickListener */

    fun setOnClickListener(listener: OnClickListener)

}

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/dagger/NotificationShelfComponent.java

+3 −2
Original line number Diff line number Diff line
@@ -16,8 +16,8 @@ 


package com.android.systemui.statusbar.notification.row.dagger;



import com.android.systemui.statusbar.LegacyNotificationShelfControllerImpl;

import com.android.systemui.statusbar.NotificationShelf;

import com.android.systemui.statusbar.NotificationShelfController;

import com.android.systemui.statusbar.notification.row.ActivatableNotificationView;



import dagger.Binds;
@@ -46,7 +46,8 @@ public interface NotificationShelfComponent { 
     * Creates a NotificationShelfController.

     */

    @NotificationRowScope

    NotificationShelfController getNotificationShelfController();

    LegacyNotificationShelfControllerImpl getNotificationShelfController();



    /**

     * Dagger Module that extracts interesting properties from a NotificationShelf.

     */