Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e225355 authored by Matt Pietal's avatar Matt Pietal
Browse files

Remove unused qs_peek_height, redundant height method 

Seems to be always 0. Removing as I am aiming to refactor calls from NPVC

Bug: 287644451
Test: atest SystemUITests
Change-Id: I295a7421cfdbee5e9fa55cf3f7c231f624f38c07
parent dffc0f9c

packages/SystemUI/res/values/dimens.xml

+0 −3
Original line number Original line Diff line number Diff line
@@ -663,9 +663,6 @@ 




    <dimen name="restricted_padlock_pading">4dp</dimen>

    <dimen name="restricted_padlock_pading">4dp</dimen>





    <!-- How far the expanded QS panel peeks from the header in collapsed state. -->

    <dimen name="qs_peek_height">0dp</dimen>



    <!-- Padding between subtitles and the following text in the QSFooter dialog -->

    <!-- Padding between subtitles and the following text in the QSFooter dialog -->

    <dimen name="qs_footer_dialog_subtitle_padding">20dp</dimen>

    <dimen name="qs_footer_dialog_subtitle_padding">20dp</dimen>

packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -1473,7 +1473,7 @@ public final class NotificationPanelViewController implements ShadeSurface, Dump 
                // so we should not add a padding for them

                // so we should not add a padding for them

                stackScrollerPadding = 0;

                stackScrollerPadding = 0;

            } else {

            } else {

                stackScrollerPadding = mQsController.getUnlockedStackScrollerPadding();

                stackScrollerPadding = mQsController.getHeaderHeight();

            }

            }

        } else {

        } else {

            stackScrollerPadding = mClockPositionResult.stackScrollerPaddingExpanded;

            stackScrollerPadding = mClockPositionResult.stackScrollerPaddingExpanded;
@@ -1520,7 +1520,7 @@ public final class NotificationPanelViewController implements ShadeSurface, Dump 
                userSwitcherPreferredY,

                userSwitcherPreferredY,

                darkAmount, mOverStretchAmount,

                darkAmount, mOverStretchAmount,

                bypassEnabled,

                bypassEnabled,

                mQsController.getUnlockedStackScrollerPadding(),

                mQsController.getHeaderHeight(),

                mQsController.computeExpansionFraction(),

                mQsController.computeExpansionFraction(),

                mDisplayTopInset,

                mDisplayTopInset,

                mSplitShadeEnabled,

                mSplitShadeEnabled,

packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java

+1 −10
Original line number Original line Diff line number Diff line
@@ -233,7 +233,6 @@ public class QuickSettingsController implements Dumpable { 
    private int mMaxExpansionHeight;

    private int mMaxExpansionHeight;

    /** Expansion fraction of the notification shade */

    /** Expansion fraction of the notification shade */

    private float mShadeExpandedFraction;

    private float mShadeExpandedFraction;

    private int mPeekHeight;

    private float mLastOverscroll;

    private float mLastOverscroll;

    private boolean mExpansionFromOverscroll;

    private boolean mExpansionFromOverscroll;

    private boolean mExpansionEnabledPolicy = true;

    private boolean mExpansionEnabledPolicy = true;
@@ -429,7 +428,6 @@ public class QuickSettingsController implements Dumpable { 
        final ViewConfiguration configuration = ViewConfiguration.get(this.mPanelView.getContext());

        final ViewConfiguration configuration = ViewConfiguration.get(this.mPanelView.getContext());

        mTouchSlop = configuration.getScaledTouchSlop();

        mTouchSlop = configuration.getScaledTouchSlop();

        mSlopMultiplier = configuration.getScaledAmbiguousGestureMultiplier();

        mSlopMultiplier = configuration.getScaledAmbiguousGestureMultiplier();

        mPeekHeight = mResources.getDimensionPixelSize(R.dimen.qs_peek_height);

        mStatusBarMinHeight = SystemBarUtils.getStatusBarHeight(mPanelView.getContext());

        mStatusBarMinHeight = SystemBarUtils.getStatusBarHeight(mPanelView.getContext());

        mScrimCornerRadius = mResources.getDimensionPixelSize(

        mScrimCornerRadius = mResources.getDimensionPixelSize(

                R.dimen.notification_scrim_corner_radius);

                R.dimen.notification_scrim_corner_radius);
@@ -500,12 +498,7 @@ public class QuickSettingsController implements Dumpable { 
    }

    }





    int getHeaderHeight() {

    int getHeaderHeight() {

        return mQs.getHeader().getHeight();

        return isQsFragmentCreated() ? mQs.getHeader().getHeight() : 0;

    }



    /** Returns the padding of the stackscroller when unlocked */

    int getUnlockedStackScrollerPadding() {

        return (mQs != null ? mQs.getHeader().getHeight() : 0) + mPeekHeight;

    }

    }





    private boolean isRemoteInputActiveWithKeyboardUp() {

    private boolean isRemoteInputActiveWithKeyboardUp() {
@@ -2090,8 +2083,6 @@ public class QuickSettingsController implements Dumpable { 
        ipw.println(mMaxExpansionHeight);

        ipw.println(mMaxExpansionHeight);

        ipw.print("mShadeExpandedFraction=");

        ipw.print("mShadeExpandedFraction=");

        ipw.println(mShadeExpandedFraction);

        ipw.println(mShadeExpandedFraction);

        ipw.print("mPeekHeight=");

        ipw.println(mPeekHeight);

        ipw.print("mLastOverscroll=");

        ipw.print("mLastOverscroll=");

        ipw.println(mLastOverscroll);

        ipw.println(mLastOverscroll);

        ipw.print("mExpansionFromOverscroll=");

        ipw.print("mExpansionFromOverscroll=");