Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4de97e65 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "GpuStats: track Vulkan apps not doing pre-rotation correctly"

parents 66e50ed9 a7638614

cmds/statsd/src/atoms.proto

+3 −0
Original line number Diff line number Diff line
@@ -6360,6 +6360,9 @@ message GpuStatsAppInfo { 


    // CPU Vulkan implementation is in use.

    optional bool cpu_vulkan_in_use = 6;



    // App is not doing pre-rotation correctly.

    optional bool false_prerotation = 7;

}



/*

cmds/statsd/src/external/GpuStatsPuller.cpp

+1 −0
Original line number Diff line number Diff line
@@ -96,6 +96,7 @@ static bool pullGpuStatsAppInfo(const sp<IGpuService>& gpuService, 
        if (!event->write(int64VectorToProtoByteString(info.vkDriverLoadingTime))) return false;

        if (!event->write(int64VectorToProtoByteString(info.angleDriverLoadingTime))) return false;

        if (!event->write(info.cpuVulkanInUse)) return false;

        if (!event->write(info.falsePrerotation)) return false;

        event->init();

        data->emplace_back(event);

    }

cmds/statsd/tests/external/GpuStatsPuller_test.cpp

+4 −1
Original line number Diff line number Diff line
@@ -56,8 +56,9 @@ static const int32_t VULKAN_VERSION = 1; 
static const int32_t CPU_VULKAN_VERSION           = 2;

static const int32_t GLES_VERSION                 = 3;

static const bool CPU_VULKAN_IN_USE               = true;

static const bool FALSE_PREROTATION               = true;

static const size_t NUMBER_OF_VALUES_GLOBAL       = 13;

static const size_t NUMBER_OF_VALUES_APP          = 6;

static const size_t NUMBER_OF_VALUES_APP          = 7;

// clang-format on



class MockGpuStatsPuller : public GpuStatsPuller {
@@ -150,6 +151,7 @@ TEST_F(GpuStatsPuller_test, PullGpuStatsAppInfo) { 
    EXPECT_TRUE(event->write(int64VectorToProtoByteString(vkDriverLoadingTime)));

    EXPECT_TRUE(event->write(int64VectorToProtoByteString(angleDriverLoadingTime)));

    EXPECT_TRUE(event->write(CPU_VULKAN_IN_USE));

    EXPECT_TRUE(event->write(FALSE_PREROTATION));

    event->init();

    inData.emplace_back(event);

    MockGpuStatsPuller mockPuller(android::util::GPU_STATS_APP_INFO, &inData);
@@ -168,6 +170,7 @@ TEST_F(GpuStatsPuller_test, PullGpuStatsAppInfo) { 
    EXPECT_EQ(int64VectorToProtoByteString(angleDriverLoadingTime),

              outData[0]->getValues()[4].mValue.str_value);

    EXPECT_EQ(CPU_VULKAN_IN_USE, outData[0]->getValues()[5].mValue.int_value);

    EXPECT_EQ(FALSE_PREROTATION, outData[0]->getValues()[6].mValue.int_value);

}



}  // namespace statsd