Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4cd1ae0c authored by Felipe Leme's avatar Felipe Leme
Browse files

Cosmetic changes on Field Classification TODOs and docs. 

Test: in TreeHugger we trust!
Bug: 73648631

Change-Id: I9390fb570e18e9636da2de27e2bc6186d5958e41
parent 2d76c3ce

core/java/android/service/autofill/AutofillService.java

+0 −1
Original line number Diff line number Diff line
@@ -528,7 +528,6 @@ import android.view.autofill.AutofillValue; 
 *     <compatibility-package android:name="foo.bar.baz" android:maxLongVersionCode="1000000000"/>

 * &lt;/autofill-service&gt;</pre>

 */

// TODO(b/70407264): add code snippets to field classification ???

public abstract class AutofillService extends Service {

    private static final String TAG = "AutofillService";

core/java/android/service/autofill/UserData.java

+6 −9
Original line number Diff line number Diff line
@@ -169,17 +169,15 @@ public final class UserData implements Parcelable { 
         * @param categoryId string used to identify the category the value is associated with.

         *

         * @throws IllegalArgumentException if any of the following occurs:

         * <ol>

         * <ul>

         *   <li>{@code id} is empty</li>

         *   <li>{@code categoryId} is empty</li>

         *   <li>{@code value} is empty</li>

         *   <li>the length of {@code value} is lower than {@link UserData#getMinValueLength()}</li>

         *   <li>the length of {@code value} is higher than

         *       {@link UserData#getMaxValueLength()}</li>

         * </ol>

         *

         * </ul>

         */

        // TODO(b/70407264): ignore entry instead of throwing exception when settings changed

        public Builder(@NonNull String id, @NonNull String value, @NonNull String categoryId) {

            mId = checkNotEmpty("id", id);

            checkNotEmpty("categoryId", categoryId);
@@ -222,26 +220,25 @@ public final class UserData implements Parcelable { 
         * @param categoryId string used to identify the category the value is associated with.

         *

         * @throws IllegalStateException if:

         * <ol>

         * <ul>

         *   <li>{@link #build()} already called</li>

         *   <li>the {@code value} has already been added</li>

         *   <li>the number of unique {@code categoryId} values added so far is more than

         *       {@link UserData#getMaxCategoryCount()}</li>

         *   <li>the number of {@code values} added so far is is more than

         *       {@link UserData#getMaxUserDataSize()}</li>

         * </ol>

         * </ul>

         *

         * @throws IllegalArgumentException if any of the following occurs:

         * <ol>

         * <ul>

         *   <li>{@code id} is empty</li>

         *   <li>{@code categoryId} is empty</li>

         *   <li>{@code value} is empty</li>

         *   <li>the length of {@code value} is lower than {@link UserData#getMinValueLength()}</li>

         *   <li>the length of {@code value} is higher than

         *       {@link UserData#getMaxValueLength()}</li>

         * </ol>

         * </ul>

         */

        // TODO(b/70407264): ignore entry instead of throwing exception when settings changed

        public Builder add(@NonNull String value, @NonNull String categoryId) {

            throwIfDestroyed();

            checkNotEmpty("categoryId", categoryId);

services/autofill/java/com/android/server/autofill/Session.java

+1 −1
Original line number Diff line number Diff line
@@ -1874,7 +1874,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
                        isIgnored ? ViewState.STATE_IGNORED : ViewState.STATE_INITIAL);

                mViewStates.put(id, viewState);



                // TODO(b/70407264): for optimization purposes, should also ignore if change is

                // TODO(b/73648631): for optimization purposes, should also ignore if change is

                // detectable, and batch-send them when the session is finished (but that will

                // require tracking detectable fields on AutofillManager)

                if (isIgnored) {