Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c6d97a1 authored by David Chen's avatar David Chen
Browse files

Fix statsd dropping metrics data. 

We can increase the buffer of metrics we store in statsd memory, but
we still request the clients to call getData when the metrics memory
exceeds 128 KB (previously was 90% of 128 KB).

Bug: 76171061
Test: Test that unit-tests still pass.
Change-Id: I901545b364ed313af8c033ce9b40d3cfadb93213
parent 0205fd10

cmds/statsd/src/StatsLogProcessor.cpp

+1 −1
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ void StatsLogProcessor::flushIfNecessaryLocked( 
        metricsManager.dropData(timestampNs);

        StatsdStats::getInstance().noteDataDropped(key);

        VLOG("StatsD had to toss out metrics for %s", key.ToString().c_str());

    } else if (totalBytes > .9 * StatsdStats::kMaxMetricsBytesPerConfig) {

    } else if (totalBytes > StatsdStats::kBytesPerConfigTriggerGetData) {

        // Send broadcast so that receivers can pull data.

        auto lastBroadcastTime = mLastBroadcastTimes.find(key);

        if (lastBroadcastTime != mLastBroadcastTimes.end()) {

cmds/statsd/src/guardrail/StatsdStats.h

+7 −3
Original line number Diff line number Diff line
@@ -96,9 +96,13 @@ public: 


    const static int kMaxLogSourceCount = 50;



    // Max memory allowed for storing metrics per configuration. When this limit is approached,

    // statsd will send a broadcast so that the client can fetch the data and clear this memory.

    static const size_t kMaxMetricsBytesPerConfig = 128 * 1024;

    // Max memory allowed for storing metrics per configuration. If this limit is exceeded, statsd

    // drops the metrics data in memory.

    static const size_t kMaxMetricsBytesPerConfig = 256 * 1024;



    // Soft memory limit per configuration. Once this limit is exceeded, we begin notifying the

    // data subscriber that it's time to call getData.

    static const size_t kBytesPerConfigTriggerGetData = 128 * 1024;



    // Cap the UID map's memory usage to this. This should be fairly high since the UID information

    // is critical for understanding the metrics.