Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c5ecbfe authored by Lucas Dupin's avatar Lucas Dupin
Browse files

Avoid recreating shader during recomposition 

Bug: 418943801
Test: manually trigger, look at glow
Flag: com.android.systemui.enable_underlay
Change-Id: Ia10dfe1fc9802d03725fc6fc8eb3186144a9b828
parent c907b9bd

packages/SystemUI/compose/features/src/com/android/systemui/ambientcue/ui/compose/BackgroundGlow.kt

+2 −3
Original line number Diff line number Diff line
@@ -81,15 +81,14 @@ fun BackgroundGlow( 
    val color2 = Color(boostChroma(MaterialTheme.colorScheme.primary.toArgb()))

    val color3 = Color(boostChroma(MaterialTheme.colorScheme.tertiary.toArgb()))



    val shader = RuntimeShader(BackgroundGlowShader.FRAG_SHADER)

    val shaderBrush = ShaderBrush(shader)

    val shader = remember { RuntimeShader(BackgroundGlowShader.FRAG_SHADER) }

    val shaderBrush = remember { ShaderBrush(shader) }



    Box(

        modifier.size(400.dp, 200.dp).alpha(alpha).drawWithCache {

            onDrawWithContent {

                val offsetX = with(density) { verticalOffset.x.dp.toPx() }

                val offsetY = with(density) { verticalOffset.y.dp.toPx() }

                shader.setFloatUniform("alpha", alpha)

                shader.setFloatUniform("resolution", size.width, size.height)

                shader.setColorUniform("color1", color1.toArgb())

                shader.setColorUniform("color2", color2.toArgb())

packages/SystemUI/compose/features/src/com/android/systemui/ambientcue/ui/shader/BackgroundGlowShader.kt

+0 −1
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ object BackgroundGlowShader { 
    uniform float2 resolution;

    uniform half2 origin;

    uniform half radius;

    uniform half alpha;

    uniform half turbulencePhase;

    uniform half turbulenceAmount;

    uniform half turbulenceSize;