Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c3b7e9a authored by Joanne Chung's avatar Joanne Chung
Browse files

Fix ServicePermissionsTest#testDumpProtected 

The translation system service should verify the caller holds
Permission#DUMP before dumpping the log.

Bug: 186756551
Test: atest ServicePermissionsTest#testDumpProtected
Test: atest CtsTranslationTestCases
Test: manual dumpsys translation

Change-Id: Ic1ea90d9467d5ac25353f08374ce157c60976b8e
parent 51f0592f

services/translation/java/com/android/server/translation/TranslationManagerService.java

+3 −0
Original line number Diff line number Diff line
@@ -48,6 +48,7 @@ import android.view.translation.UiTranslationSpec; 


import com.android.internal.annotations.GuardedBy;

import com.android.internal.os.IResultReceiver;

import com.android.internal.util.DumpUtils;

import com.android.server.infra.AbstractMasterSystemService;

import com.android.server.infra.FrameworkResourcesServiceNameResolver;
@@ -289,6 +290,8 @@ public final class TranslationManagerService 
        */

        @Override

        public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

            if (!DumpUtils.checkDumpPermission(getContext(), TAG, pw)) return;



            synchronized (mLock) {

                dumpLocked("", pw);

            }