Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c3915a0 authored by Kenny Root's avatar Kenny Root
Browse files

Do not check features in PackageManagerService 

PackageManagerService shouldn't check features that a package declares
that it uses because this will cause problems in the future when we add
more features that older phones didn't explicitly declare. We must rely
on markets to know about phones and filter them for us to avoid this
situation.

Bug: 3409434
Change-Id: I419a5b936be3572b83a485081a6c81b2f1c8741c
parent cb9d4d28

core/tests/coretests/src/android/content/pm/PackageManagerTests.java

+12 −3
Original line number Diff line number Diff line
@@ -3098,10 +3098,19 @@ public class PackageManagerTests extends AndroidTestCase { 
                fail, retCode, PackageInfo.INSTALL_LOCATION_UNSPECIFIED);

    }



    /**

     * Unknown features should be allowed to install. This prevents older phones

     * from rejecting new packages that specify features that didn't exist when

     * an older phone existed. All older phones are assumed to have those

     * features.

     * <p>

     * Right now we allow all packages to be installed regardless of their

     * features.

     */

    @LargeTest

    public void testUsesFeatureMissingFeature() {

        int retCode = PackageManager.INSTALL_FAILED_MISSING_FEATURE;

        installFromRawResource("install.apk", R.raw.install_uses_feature, 0, true, true, retCode,

    public void testUsesFeatureUnknownFeature() {

        int retCode = PackageManager.INSTALL_SUCCEEDED;

        installFromRawResource("install.apk", R.raw.install_uses_feature, 0, true, false, retCode,

                PackageInfo.INSTALL_LOCATION_UNSPECIFIED);

    }

services/java/com/android/server/PackageManagerService.java

+0 −20
Original line number Diff line number Diff line
@@ -2924,26 +2924,6 @@ class PackageManagerService extends IPackageManager.Stub { 
                }

            }



            if (pkg.reqFeatures != null) {

                int N = pkg.reqFeatures.size();

                for (int i = 0; i < N; i++) {

                    FeatureInfo fi = pkg.reqFeatures.get(i);

                    if ((fi.flags & FeatureInfo.FLAG_REQUIRED) == 0) {

                        // Don't care.

                        continue;

                    }



                    if (fi.name != null) {

                        if (mAvailableFeatures.get(fi.name) == null) {

                            Slog.e(TAG, "Package " + pkg.packageName

                                    + " requires unavailable feature " + fi.name + "; failing!");

                            mLastScanError = PackageManager.INSTALL_FAILED_MISSING_FEATURE;

                            return null;

                        }

                    }

                }

            }



            if (pkg.mSharedUserId != null) {

                suid = mSettings.getSharedUserLP(pkg.mSharedUserId,

                        pkg.applicationInfo.flags, true);