Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bd87d6e authored by Ben Murdoch's avatar Ben Murdoch
Browse files

Disable AutoFill in private browsing mode. 

Ensure that WebKit knows that AutoFill is disabled when private
browsing is on.

Bug: 3335257
Change-Id: I8c3e45175211e5cb00605c1dbf974e513c582d8e
parent f46013b6

core/java/android/webkit/WebSettings.java

+9 −2
Original line number Diff line number Diff line
@@ -1629,6 +1629,11 @@ public class WebSettings { 
    /* package */ synchronized void setPrivateBrowsingEnabled(boolean flag) {

        if (mPrivateBrowsingEnabled != flag) {

            mPrivateBrowsingEnabled = flag;



            // AutoFill is dependant on private browsing being enabled so

            // reset it to take account of the new value of mPrivateBrowsingEnabled.

            setAutoFillEnabled(mAutoFillEnabled);



            postSync();

        }

    }
@@ -1644,8 +1649,10 @@ public class WebSettings { 
     * @hide

     */

    public synchronized void setAutoFillEnabled(boolean enabled) {

        if (mAutoFillEnabled != enabled) {

            mAutoFillEnabled = enabled;

        // AutoFill is always disabled in private browsing mode.

        boolean autoFillEnabled = enabled && !mPrivateBrowsingEnabled;

        if (mAutoFillEnabled != autoFillEnabled) {

            mAutoFillEnabled = autoFillEnabled;

            postSync();

        }

    }