Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b3c0ff2 authored by Gus Prevas's avatar Gus Prevas
Browse files

Fixes min priority notifications in shelf. 

This change fixes an issue where min priority notifications were no
longer appearing in the notification shelf, leading to display glitches
while scrolling the notification shade.  ag/5220056 incorrectly inlined
the constant NotificationShelf.SHOW_AMBIENT_ICONS as false in two places
instead of true, which caused the issue.

Bug: 111405682
Test: manually
Change-Id: I5dbbdc2749b31464838ec9b9b4e04a4de687af12
parent 1e5b5d03

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java

+1 −3
Original line number Diff line number Diff line
@@ -1499,9 +1499,7 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 
    }



    private void updateIconVisibilities() {

        boolean visible = isChildInGroup()

                || isBelowSpeedBump()

                || mIconsVisible;

        boolean visible = isChildInGroup() || mIconsVisible;

        for (NotificationContentView l : mLayouts) {

            l.setIconsVisible(visible);

        }

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconAreaController.java

+1 −1
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ public class NotificationIconAreaController implements DarkReceiver { 


    private void updateShelfIcons() {

        updateIconsForLayout(entry -> entry.expandedIcon, mShelfIcons,

                false /* showAmbient */, !mFullyDark /* showLowPriority */,

                true /* showAmbient */, !mFullyDark /* showLowPriority */,

                false /* hideDismissed */, mFullyDark /* hideRepliedMessages */);

    }