Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4add16c4 authored by Mihai Popa's avatar Mihai Popa
Browse files

Stop window redraws for invisible parent children 

Bug: 69046604
Test: atest CtsViewTestCases:android.view.cts.ViewTest
Change-Id: If9f2d4212d613cb7122806adb31ad7ad875c8e45
parent 095adc27

core/java/android/view/View.java

+8 −16
Original line number Diff line number Diff line
@@ -17899,7 +17899,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
        final int scrollX = mScrollX;

        final int scrollY = mScrollY;

        invalidateInternal(dirty.left - scrollX, dirty.top - scrollY,

                dirty.right - scrollX, dirty.bottom - scrollY, true, false);

                dirty.right - scrollX, dirty.bottom - scrollY, true);

    }















    /**









@@ -17925,7 +17925,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













    public void invalidate(int l, int t, int r, int b) {















        final int scrollX = mScrollX;















        final int scrollY = mScrollY;













        invalidateInternal(l - scrollX, t - scrollY, r - scrollX, b - scrollY, true, false);













        invalidateInternal(l - scrollX, t - scrollY, r - scrollX, b - scrollY, true);















    }





























    /**










@@ -17955,11 +17955,10 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













     */















    @UnsupportedAppUsage















    public void invalidate(boolean invalidateCache) {













        invalidateInternal(0, 0, mRight - mLeft, mBottom - mTop, invalidateCache, true);













        invalidateInternal(0, 0, mRight - mLeft, mBottom - mTop, invalidateCache);















    }



























    void invalidateInternal(int l, int t, int r, int b, boolean invalidateCache,













            boolean fullInvalidate) {













    void invalidateInternal(int l, int t, int r, int b, boolean invalidateCache) {















        if (mGhostView != null) {















            mGhostView.invalidate(true);















            return;









@@ -17976,11 +17975,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













        if ((mPrivateFlags & (PFLAG_DRAWN | PFLAG_HAS_BOUNDS)) == (PFLAG_DRAWN | PFLAG_HAS_BOUNDS)















                || (invalidateCache && (mPrivateFlags & PFLAG_DRAWING_CACHE_VALID) == PFLAG_DRAWING_CACHE_VALID)















                || (mPrivateFlags & PFLAG_INVALIDATED) != PFLAG_INVALIDATED













                || (fullInvalidate && isOpaque() != mLastIsOpaque)) {













            if (fullInvalidate) {













                || isOpaque() != mLastIsOpaque) {















            mLastIsOpaque = isOpaque();















            mPrivateFlags &= ~PFLAG_DRAWN;













            }





























            mPrivateFlags |= PFLAG_DIRTY;
























@@ -22525,12 +22522,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













    @Override















    public void invalidateDrawable(@NonNull Drawable drawable) {















        if (verifyDrawable(drawable)) {













            final Rect dirty = drawable.getDirtyBounds();













            final int scrollX = mScrollX;













            final int scrollY = mScrollY;

























            invalidate(dirty.left + scrollX, dirty.top + scrollY,













                    dirty.right + scrollX, dirty.bottom + scrollY);













            invalidate();















            rebuildOutline();















        }















    }