Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a9fc440 authored by hupeng3's avatar hupeng3 Committed by Hu Peng
Browse files

Toast: Solve the NPE problem in session.java 



In the if statement here, 'isFillDialogUiEnabled' should not be an
independent '||' operation, which will cause the previous addition to be
invalid. It should be in the same level as 'isViewFocusedLocked', and
use 'isRequestSupportFillDialog' replace.

Bug: 267986308

Test: Manual

Signed-off-by: default avatarhupeng3 <hp121520@gmail.com>
Change-Id: I8adc5eb7f24f2189e22b469f7c677bb2206cf3c8
parent 52cdf737

services/autofill/java/com/android/server/autofill/Session.java

+1 −2
Original line number Diff line number Diff line
@@ -3840,8 +3840,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
                && (mSessionFlags.mAugmentedAutofillOnly

                        || !mSessionFlags.mInlineSupportedByService

                        || mSessionFlags.mExpiredResponse)

                && isViewFocusedLocked(flags)

                || isFillDialogUiEnabled()) {

                && (isViewFocusedLocked(flags) || isRequestSupportFillDialog(flags))) {

            if (sDebug) Slog.d(TAG, "Create inline request for augmented autofill");

            remoteRenderService.getInlineSuggestionsRendererInfo(new RemoteCallback(

                    (extras) -> {