Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a7931dc authored by Geoffrey Pitsch's avatar Geoffrey Pitsch
Browse files

Unit tests for PowerNotificationWarnings 

Just a sample - this is a far cry from full coverage. Mostly
exercises the handoff to the NotificationManager. To go further,
I would verify more of the Notification contents.

Modified the constructor to explicitly take a NotificationManager,
mocking out the Context wasn't feasible here.

Change-Id: Ic83ef17f061a20efc52b7e3e8c022afab2deacdb
parent 182f9abd

packages/SystemUI/src/com/android/systemui/power/PowerNotificationWarnings.java

+5 −3
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ import android.media.AudioAttributes; 
import android.net.Uri;

import android.os.AsyncTask;

import android.os.Handler;

import android.os.Looper;

import android.os.PowerManager;

import android.os.SystemClock;

import android.os.UserHandle;
@@ -73,7 +74,7 @@ public class PowerNotificationWarnings implements PowerUI.WarningsUI { 
    private final Context mContext;

    private final NotificationManager mNoMan;

    private final PowerManager mPowerMan;

    private final Handler mHandler = new Handler();

    private final Handler mHandler = new Handler(Looper.getMainLooper());

    private final Receiver mReceiver = new Receiver();

    private final Intent mOpenBatterySettings = settings(Intent.ACTION_POWER_USAGE_SUMMARY);
@@ -89,9 +90,10 @@ public class PowerNotificationWarnings implements PowerUI.WarningsUI { 
    private boolean mInvalidCharger;

    private SystemUIDialog mSaverConfirmation;



    public PowerNotificationWarnings(Context context, PhoneStatusBar phoneStatusBar) {

    public PowerNotificationWarnings(Context context, NotificationManager notificationManager,

            PhoneStatusBar phoneStatusBar) {

        mContext = context;

        mNoMan = (NotificationManager) context.getSystemService(Context.NOTIFICATION_SERVICE);

        mNoMan = notificationManager;

        mPowerMan = (PowerManager) context.getSystemService(Context.POWER_SERVICE);

        mReceiver.init();

    }

packages/SystemUI/src/com/android/systemui/power/PowerUI.java

+5 −3
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.systemui.power;



import android.app.NotificationManager;

import android.content.BroadcastReceiver;

import android.content.ContentResolver;

import android.content.Context;
@@ -30,10 +31,8 @@ import android.os.UserHandle; 
import android.provider.Settings;

import android.util.Log;

import android.util.Slog;



import com.android.systemui.SystemUI;

import com.android.systemui.statusbar.phone.PhoneStatusBar;



import java.io.FileDescriptor;

import java.io.PrintWriter;

import java.util.Arrays;
@@ -60,7 +59,10 @@ public class PowerUI extends SystemUI { 
    public void start() {

        mPowerManager = (PowerManager) mContext.getSystemService(Context.POWER_SERVICE);

        mScreenOffTime = mPowerManager.isScreenOn() ? -1 : SystemClock.elapsedRealtime();

        mWarnings = new PowerNotificationWarnings(mContext, getComponent(PhoneStatusBar.class));

        mWarnings = new PowerNotificationWarnings(

                mContext,

                (NotificationManager) mContext.getSystemService(Context.NOTIFICATION_SERVICE),

                getComponent(PhoneStatusBar.class));



        ContentObserver obs = new ContentObserver(mHandler) {

            @Override

packages/SystemUI/tests/src/com/android/systemui/power/PowerNotificationWarningsTest.java

0 → 100644
+116 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2016 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.systemui.power;



import static android.test.MoreAsserts.assertNotEqual;

import static junit.framework.Assert.assertEquals;

import static junit.framework.Assert.assertFalse;

import static junit.framework.Assert.assertTrue;

import static org.mockito.Mockito.any;

import static org.mockito.Mockito.anyInt;

import static org.mockito.Mockito.anyString;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;



import android.app.Notification;

import android.app.NotificationManager;

import android.support.test.InstrumentationRegistry;

import android.support.test.runner.AndroidJUnit4;

import android.test.suitebuilder.annotation.SmallTest;

import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.ArgumentCaptor;



@SmallTest

@RunWith(AndroidJUnit4.class)

public class PowerNotificationWarningsTest {

    private final NotificationManager mMockNotificationManager = mock(NotificationManager.class);

    private PowerNotificationWarnings mPowerNotificationWarnings;



    @Before

    public void setUp() throws Exception {

        // Test Instance.

        mPowerNotificationWarnings = new PowerNotificationWarnings(

                InstrumentationRegistry.getTargetContext(), mMockNotificationManager, null);

    }



    @Test

    public void testIsInvalidChargerWarningShowing_DefaultsToFalse() {

        assertFalse(mPowerNotificationWarnings.isInvalidChargerWarningShowing());

    }



    @Test

    public void testIsInvalidChargerWarningShowing_TrueAfterShow() {

        mPowerNotificationWarnings.showInvalidChargerWarning();

        assertTrue(mPowerNotificationWarnings.isInvalidChargerWarningShowing());

    }



    @Test

    public void testIsInvalidChargerWarningShowing_FalseAfterDismiss() {

        mPowerNotificationWarnings.showInvalidChargerWarning();

        mPowerNotificationWarnings.dismissInvalidChargerWarning();

        assertFalse(mPowerNotificationWarnings.isInvalidChargerWarningShowing());

    }



    @Test

    public void testShowInvalidChargerNotification_NotifyAsUser() {

        mPowerNotificationWarnings.showInvalidChargerWarning();

        verify(mMockNotificationManager, times(1))

                .notifyAsUser(anyString(), anyInt(), any(), any());

    }



    @Test

    public void testDismissInvalidChargerNotification_CancelAsUser() {

        mPowerNotificationWarnings.showInvalidChargerWarning();

        mPowerNotificationWarnings.dismissInvalidChargerWarning();

        verify(mMockNotificationManager, times(1)).cancelAsUser(anyString(), anyInt(), any());

    }



    @Test

    public void testShowLowBatteryNotification_NotifyAsUser() {

        mPowerNotificationWarnings.showLowBatteryWarning(false);

        verify(mMockNotificationManager, times(1))

                .notifyAsUser(anyString(), anyInt(), any(), any());

    }



    @Test

    public void testDismissLowBatteryNotification_CancelAsUser() {

        mPowerNotificationWarnings.showLowBatteryWarning(false);

        mPowerNotificationWarnings.dismissLowBatteryWarning();

        verify(mMockNotificationManager, times(1)).cancelAsUser(anyString(), anyInt(), any());

    }



    @Test

    public void testShowLowBatteryNotification_Silent() {

        mPowerNotificationWarnings.showLowBatteryWarning(false);

        ArgumentCaptor<Notification> captor = ArgumentCaptor.forClass(Notification.class);

        verify(mMockNotificationManager)

                .notifyAsUser(anyString(), anyInt(), captor.capture(), any());

        assertEquals(null, captor.getValue().sound);

    }



    @Test

    public void testShowLowBatteryNotification_Sound() {

        mPowerNotificationWarnings.showLowBatteryWarning(true);

        ArgumentCaptor<Notification> captor = ArgumentCaptor.forClass(Notification.class);

        verify(mMockNotificationManager)

                .notifyAsUser(anyString(), anyInt(), captor.capture(), any());

        assertNotEqual(null, captor.getValue().sound);

    }

}