Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a3bb613 authored by woongki min's avatar woongki min Committed by Luca Stefani
Browse files

Reduce unnecessary NotificationListener binder transaction. 

When package suspend occurs, API calls are made as many as the number of changed packages,
resulting in unnecessary binder transactions.
This can rapidly consume the async space on the NotificationListener side, such as the SystemUI.

JavaBinder: !!! FAILED BINDER TRANSACTION !!!  (parcel size = 8844)
NotificationListeners: unable to notify listener (posted): android.service.notification.INotificationListener$Stub$Proxy@8ed47e2
NotificationListeners: android.os.DeadObjectException: Transaction failed on small parcel; remote process probably died

Test: Occurs ACTION_PACKAGES_UNSUSPENDED/SUSPENDED with a pkgList size of 50 or more
Test: Async space of SystemUI(NotificationListener) decreases and binder transaction fails.

Change-Id: I58d42ecf39e13b3adce7652ae72147de0be00e89
parent 8dfaa86b

services/core/java/com/android/server/notification/NotificationManagerService.java

100644 → 100755
+6 −7
Original line number Diff line number Diff line
@@ -1287,17 +1287,16 @@ public class NotificationManagerService extends SystemService { 
                    uidList = new int[] {intent.getIntExtra(Intent.EXTRA_UID, -1)};

                }

                if (pkgList != null && (pkgList.length > 0)) {

                    for (String pkgName : pkgList) {

                    if (cancelNotifications) {

                        for (String pkgName : pkgList) {

                            cancelAllNotificationsInt(MY_UID, MY_PID, pkgName, null, 0, 0,

                                    !queryRestart, changeUserId, reason, null);

                        }

                    } else if (hideNotifications) {

                        hideNotificationsForPackages(pkgList);

                    } else if (unhideNotifications) {

                        unhideNotificationsForPackages(pkgList);

                    }



                    }

                }



                mHandler.scheduleOnPackageChanged(removingPackage, changeUserId, pkgList, uidList);

services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java

100644 → 100755
+6 −2
Original line number Diff line number Diff line
@@ -3601,7 +3601,9 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
        mService.simulatePackageDistractionBroadcast(

                PackageManager.RESTRICTION_HIDE_NOTIFICATIONS, new String[] {"a", "b"});

        ArgumentCaptor<List<NotificationRecord>> captorHide = ArgumentCaptor.forClass(List.class);

        verify(mListeners, times(2)).notifyHiddenLocked(captorHide.capture());



        // should be called only once.

        verify(mListeners, times(1)).notifyHiddenLocked(captorHide.capture());

        assertEquals(2, captorHide.getValue().size());

        assertEquals("a", captorHide.getValue().get(0).sbn.getPackageName());

        assertEquals("b", captorHide.getValue().get(1).sbn.getPackageName());
@@ -3610,7 +3612,9 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
        mService.simulatePackageDistractionBroadcast(

                PackageManager.RESTRICTION_HIDE_FROM_SUGGESTIONS, new String[] {"a", "b"});

        ArgumentCaptor<List<NotificationRecord>> captorUnhide = ArgumentCaptor.forClass(List.class);

        verify(mListeners, times(2)).notifyUnhiddenLocked(captorUnhide.capture());



        // should be called only once.

        verify(mListeners, times(1)).notifyUnhiddenLocked(captorUnhide.capture());

        assertEquals(2, captorUnhide.getValue().size());

        assertEquals("a", captorUnhide.getValue().get(0).sbn.getPackageName());

        assertEquals("b", captorUnhide.getValue().get(1).sbn.getPackageName());