Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48fa1b22 authored by Josh's avatar Josh
Browse files

Use correct package name to create Icons for Apps 

Previously we used SystemUI Context which resulted in 3P apps having
Icons with the wrong packageName com.android.systemui. To fix this,
we're now directly passing in the correct package name to create the
icon.

Bug: 403244725
Flag: com.android.systemui.extended_apps_shortcut_category
Test: InputGestureDataAdapterTest
Change-Id: I9decf36534e637648ee158d1f326f701e88b3b0f
parent 9cccf61c

packages/SystemUI/multivalentTests/src/com/android/systemui/keyboard/shortcut/data/repository/InputGestureDataAdapterTest.kt

+1 −0
Original line number Diff line number Diff line
@@ -77,6 +77,7 @@ class InputGestureDataAdapterTest : SysuiTestCase() { 
            name = FAKE_ACTIVITY_NAME

            icon = 0x1

            nonLocalizedLabel = TEST_SHORTCUT_LABEL

            packageName = TEST_ROLE_PACKAGE

        }

    private val mockSelectorIntent: Intent = mock()

packages/SystemUI/src/com/android/systemui/keyboard/shortcut/data/repository/InputGestureDataAdapter.kt

+1 −1
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ constructor( 
        return if (resolvedActivity == null) {

            null

        } else {

            Icon.createWithResource(context, resolvedActivity.iconResource)

            Icon.createWithResource(resolvedActivity.packageName, resolvedActivity.iconResource)

        }

    }