Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48ba06f2 authored by Vladimir Komsiyski's avatar Vladimir Komsiyski
Browse files

Update the system decorations flag docs. 

The flag is not related to IME logic anymore; it only controls
navbar, home and wallpaper.

Also remove the obsolete TODO.

Fix: 297168439
Test: n/a
Change-Id: I100acbd72d311dab9797045a7e317368877500b3
parent fe810dc2

core/java/android/hardware/display/DisplayManager.java

+1 −2
Original line number Diff line number Diff line
@@ -403,14 +403,13 @@ public final class DisplayManager { 


    /**

     * Virtual display flag: Indicates that the display should support system decorations. Virtual

     * displays without this flag shouldn't show home, IME or any other system decorations.

     * displays without this flag shouldn't show home, navigation bar or wallpaper.

     * <p>This flag doesn't work without {@link #VIRTUAL_DISPLAY_FLAG_TRUSTED}</p>

     *

     * @see #createVirtualDisplay

     * @see #VIRTUAL_DISPLAY_FLAG_TRUSTED

     * @hide

     */

    // TODO (b/114338689): Remove the flag and use IWindowManager#setShouldShowSystemDecors

    @TestApi

    public static final int VIRTUAL_DISPLAY_FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS = 1 << 9;

core/java/android/view/Display.java

+2 −3
Original line number Diff line number Diff line
@@ -276,15 +276,14 @@ public final class Display { 
    /**

     * Display flag: Indicates that the display should show system decorations.

     * <p>

     * This flag identifies secondary displays that should show system decorations, such as status

     * bar, navigation bar, home activity or IME.

     * This flag identifies secondary displays that should show system decorations, such as

     * navigation bar, home activity or wallpaper.

     * </p>

     * <p>Note that this flag doesn't work without {@link #FLAG_TRUSTED}</p>

     *

     * @see #getFlags()

     * @hide

     */

    // TODO (b/114338689): Remove the flag and use IWindowManager#setShouldShowSystemDecors

    public static final int FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS = 1 << 6;



    /**

services/core/java/com/android/server/display/DisplayDeviceInfo.java

+1 −2
Original line number Diff line number Diff line
@@ -122,11 +122,10 @@ final class DisplayDeviceInfo { 


    /**

     * Flag: This flag identifies secondary displays that should show system decorations, such as

     * status bar, navigation bar, home activity or IME.

     * navigation bar, home activity or wallpaper.

     * <p>Note that this flag doesn't work without {@link #FLAG_TRUSTED}</p>

     * @hide

     */

    // TODO (b/114338689): Remove the flag and use IWindowManager#setShouldShowSystemDecors

    public static final int FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS = 1 << 12;



    /**