Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 47af45a4 authored by HrX03's avatar HrX03 Committed by Bruno Martins
Browse files

SystemUI: Bring back expanded volume panel



Author: HrX03 <dn.bianco03@gmail.com>
Date:   Thu Mar 7 17:50:40 2019 +0000

    VolumeDialog: Redo expanded volume panel

    [ HrX03 | AgentFabulous - POSP ]
    - Google nuked expanded volume panel in pie. Redo the current
      implementation to bring this back from the past and dejank it.
    - Back to Android 8.x functionality!

    - Show the media output selector to not loose functionality.
    - Increase ringer vibrate icon width/height to 24 to match the
      other icons

    Change-Id: Ie4931a4ae09483ba737a74fc32ed0a1f6acf105d
Co-authored-by: default avatarKshitij Gupta <kshitijgm@gmail.com>
Co-authored-by: default avatarArian <arian.kulmer@web.de>
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>
Signed-off-by: default avataralthafvly <althafvly@gmail.com>

Author: Arian <arian.kulmer@web.de>
Date:   Wed Jun 24 03:12:02 2020 +0800

    SystemUI: fix size of icon of vibrate ringer mode

    Vibrate ringer mode icon uses 19dp height and width while
    all other ringer modes use 24dp. This leads to inconsistent
    and ugly vibrate icon in volume panel.

    Change-Id: I8733aef4e9a68fe994815e5c8d92afe60f48f704
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Jesse Chan <jc@lineageos.org>
Date:   Wed Jun 24 05:41:39 2020 +0800

    VolumeDialog: display default row when active row is notification

    Commit "frameworks: Add unlinked ringtone and notification volumes"
    introduced STREAM_NOTIFICATION. However, this stream type, although
    marked as important, was not added to the list in shouldBeVisibleH.
    As a result, the volume panel behavior of STREAM_NOTIFICATION deviates
    from other user-facing streams like media, call and ring.

    This change adds STREAM_NOTIFICATION so the behavior becomes consistent.

    Change-Id: I092c5bf0ae8cbee85af6adfa0da308dfdb60e66a
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Jesse Chan <jc@lineageos.org>
Date:   Wed Jun 24 06:08:19 2020 +0800

    VolumeDialog: notifyVisible after the volume panel is fully hidden

    notifyVisible(false) leads to reset of active stream. As a result,
    the current active row will be untinted. Currently, this happens
    immediately after the dismissal is requested, before the volume panel
    is fully hidden.

    User can notice the row has been untinted before the panel is hidden.

    This changes moves notifyVisible to the end of animation so the volume
    panel appearance will be consistent in between.

    Change-Id: Iacd83d48634a11bc248c9a2a45b68b53256fdcb2
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: HrX03 <dn.bianco03@gmail.com>
Date:   Sun Jun 21 14:08:53 2020 +0200

    VolumeDialog: Convert CustomDialog to a View and configure ViewTreeObserver

    * This lets us pass touch events to the parent view while
      using match_parent width to avoid jumpy animations.

    Thanks to Alex (treydev) for the ViewTreeInspector animation trick!

    Change-Id: Ie3c9af4d9f45b688c6a82ec37ae1c7d1a116ac8d

Author: Arian <arian.kulmer@web.de>
Date:   Tue May 26 22:13:26 2020 +0200

    VolumeDialog: Show the notification stream when unlinked

    Change-Id: I0e6d0dda5c0f57181ea94f4b249465fe42e5fb02
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Arian <arian.kulmer@web.de>
Date:   Wed May 27 00:38:47 2020 +0200

    VolumeDialog: Set the gravity and rotation based on the panels location

    Change-Id: Id59378ef9b980908d9bb05369f131deb27d3bb28
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Giuseppe Maggio <jertlok@protonmail.com>
Date:   Wed Mar 13 22:31:57 2019 +0100

    VolumeDialog: Hide the music row if there is an ally stream

    - Introduce the concept of tracking ally streams, useful
      when you are still on a call, for instance, but you also
      want to change the media volume for a future use. When
      you tap on the media row the calling row will disappear
      because of AOSP logic. With this patch, we hide the music
      row if there is a "special" row, like the voice call volume
      row, and show it on the expanded panel like our other custom
      rows. After collapsing the expanded panel we set active
      stream back to this "special" row.

    Change-Id: I23792369cf1fd8e0b4d6913c67d02bd4c09f1ac7
Co-authored-by: default avatarArian <arian.kulmer@web.de>
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Arian <arian.kulmer@web.de>
Date:   Sun May 31 13:40:13 2020 +0200

    VolumeDialog: Fix muting streams with a minimal volume of 1

    * Alarm and voice call streams report 1 as levelMin
      and hence ss.muted is never true, so that the muted
      icon never shows. After the first tap lastAudibleLevel
      is 1 so that the second tap only sets it back to 1,
      the minimal value for some streams.
      That leads to a bad UX when tapping on the icon
      because the first tap sets it to the minimal level and
      another tap just keeps it there.

    * With this patch we only set lastAudibleLevel if the
      current level is higher then levelMin instead of the
      hard-coded value of 0 so that the first tap sets the
      volume to its minimal value and the icon changes to the
      muted icon and the second tap restores the previous volume.

    * Also replace the check to show the muted icon with a check
      wether the current level is the minimal level.

    * Increase the default value of lastAudibleLevel to 2 so that
      it is never equal to the minimal value.

    Change-Id: I6d0d3960a42c949e2afd61eab86f5e3ffb8fa1b5
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Arian <arian.kulmer@web.de>
Date:   Sun May 31 15:28:04 2020 +0200

    VolumeDialog: Treat ring volume the same as others on icon tap

    * We don't need to treat the ring volume different here,
      if it's set to 0 it already sets the ringer mode to
      vibration on supported devices.

    * This makes sure that the row still displays the correct
      volume after tapping the icon, previously it only changed
      the ringer mode but left the slider at the previous value.

    Change-Id: Iabd18246c41c102ad0c1f49b7525cd188b01a7c4
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Arian <arian.kulmer@web.de>
Date:   Fri Jun 12 17:34:45 2020 +0200

    VolumeDialog: Move the media output selector next to the expandable indicator

    * Keep the non-expanded panel as slim as possible.

    Change-Id: Ic0d171c1f52ad8f50e14f161431e41d49da6cad6

Author: Jesse Chan <jc@lineageos.org>
Date:   Fri Jun 5 02:17:36 2020 +0800

    VolumeDialog: Implement expand/collapse animation

    Change-Id: Ic226d3d22fc434df7cd265c77fb99c33664e974b
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>

Author: Arian <arian.kulmer@web.de>
Date:   Sat Aug 1 14:38:27 2020 +0200

    VolumeDialog: Prevent hiding the ally stream

    * There is a rare case that the ally stream is one of the streams
      we add at the expanded panel. In this case while collapsing we
      would remove the ally stream which results in not showing a
      stream at all. (Steps to reproduce: While receiving a call,
      open the volume panel, expand it and collapse it again.)

    * Fix that by testing if the stream to hide while collapsing is the
      ally stream and if it is, do not hide it.

    Change-Id: Iab4c57ab3ded2c61124594320d5109a52c77f167

Author: Arian <arian.kulmer@web.de>
Date:   Thu Aug 27 22:53:15 2020 +0200

    VolumeDialog: Don't change the background of the expandable indicator

    * Add a divider between the rows the expandable indicator instead

    Change-Id: I912e007c895935c7b16bb605503486396546c90c

Change-Id: Ie4931a4ae09483ba737a74fc32ed0a1f6acf105d
Co-authored-by: default avatarKshitij Gupta <kshitijgm@gmail.com>
Co-authored-by: default avatarArian <arian.kulmer@web.de>
Signed-off-by: default avatarJesse Chan <jc@lineageos.org>
parent 2f09baca
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment