Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47acf93d authored by Garfield Tan's avatar Garfield Tan
Browse files

Hide CaptionDecorView behind CAPTION_ON_SHELL flag 

Also introduce a system property to facilitate debugging of caption in
shell.

Bug: 165794636
Test: Caption shows when the property is unset. Caption goes away when
the property is set.

Change-Id: I57060778c46da217a957910f0cc9d1fe1592cfa1
parent d9fe67ca

core/java/android/view/ViewRootImpl.java

+2 −1
Original line number Diff line number Diff line
@@ -278,7 +278,8 @@ public final class ViewRootImpl implements ViewParent, 
     * Whether the caption is drawn by the shell.

     * @hide

     */

    public static final boolean CAPTION_ON_SHELL = false;

    public static final boolean CAPTION_ON_SHELL =

            SystemProperties.getBoolean("persist.debug.caption_on_shell", false);



    /**

     * Whether the client should compute the window frame on its own.

core/java/com/android/internal/policy/DecorView.java

+2 −1
Original line number Diff line number Diff line
@@ -2261,7 +2261,8 @@ public class DecorView extends FrameLayout implements RootViewSurfaceTaker, Wind 
                attrs.type == TYPE_APPLICATION || attrs.type == TYPE_DRAWN_APPLICATION;

        final WindowConfiguration winConfig = getResources().getConfiguration().windowConfiguration;

        // Only a non floating application window on one of the allowed workspaces can get a caption

        if (!mWindow.isFloating() && isApplication && winConfig.hasWindowDecorCaption()) {

        if (!mWindow.isFloating() && isApplication && winConfig.hasWindowDecorCaption()

                && !CAPTION_ON_SHELL) {

            // Dependent on the brightness of the used title we either use the

            // dark or the light button frame.

            if (decorCaptionView == null) {