Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4745fb6b authored by Felipe Leme's avatar Felipe Leme
Browse files

Fixed placemente of Autofill UI for virtual views. 

The PopupWindow anchoring offset should be based on the bottom of the anchor
view, but we were using top. Hence, the PopupWindow.tryFitVertical() was
failing to place it above the view in some cases, even when there was plenty
of space.

Fixes: 37991460
Test: manual verification with virtual view sample
Test: CtsAutoFillServiceTestCases pass

Change-Id: Iffdfe0d7858e865192338184d63bf5b93ba7108f
parent f37f1f19

core/java/android/app/Activity.java

+1 −1
Original line number Diff line number Diff line
@@ -7443,7 +7443,7 @@ public class Activity extends ContextThemeWrapper 
        final int offsetX = (anchorBounds != null)

                ? anchorBounds.left - actualAnchorBounds.left : 0;

        int offsetY = (anchorBounds != null)

                ? anchorBounds.top - actualAnchorBounds.top : 0;

                ? anchorBounds.bottom - actualAnchorBounds.bottom : 0;



        final boolean wasShowing;

services/autofill/java/com/android/server/autofill/ui/FillUi.java

+6 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 
package com.android.server.autofill.ui;



import static com.android.server.autofill.Helper.sDebug;

import static com.android.server.autofill.Helper.sVerbose;



import android.annotation.NonNull;

import android.annotation.Nullable;
@@ -334,6 +335,11 @@ final class FillUi { 
        @Override

        public void show(WindowManager.LayoutParams p, Rect transitionEpicenter,

                boolean fitsSystemWindows, int layoutDirection) {

            if (sVerbose) {

                Slog.v(TAG, "AutofillWindowPresenter.show(): fit=" + fitsSystemWindows

                        + ", epicenter="+ transitionEpicenter + ", dir=" + layoutDirection

                        + ", params=" + p);

            }

            UiThread.getHandler().post(() -> mWindow.show(p));

        }