Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 468d81d0 authored by Evan Rosky's avatar Evan Rosky
Browse files

Always abort a rejected multiwindow request 

Otherwise, it continues to build a transition, but skips
sending a request to shell.

Bug: 278781290
Test: FreeformWindowingModeTests
Change-Id: I6dd05273bdb959e68154c433233b9e17f815bea7
parent ddb2fb71

services/core/java/com/android/server/wm/ActivityClientController.java

+1 −3
Original line number Diff line number Diff line
@@ -1162,9 +1162,7 @@ class ActivityClientController extends IActivityClientController.Stub { 
                fullscreenRequest, r);

        reportMultiwindowFullscreenRequestValidatingResult(callback, validateResult);

        if (validateResult != RESULT_APPROVED) {

            if (queued) {

            transition.abort();

            }

            return;

        }

        transition.collect(topFocusedRootTask);

services/core/java/com/android/server/wm/Transition.java

+5 −0
Original line number Diff line number Diff line
@@ -1486,6 +1486,11 @@ class Transition implements BLASTSyncEngine.TransactionReadyListener { 
            return;

        }



        if (mState != STATE_STARTED) {

            Slog.e(TAG, "Playing a Transition which hasn't started! #" + mSyncId + " This will "

                    + "likely cause an exception in Shell");

        }



        mState = STATE_PLAYING;

        mStartTransaction = transaction;

        mFinishTransaction = mController.mAtm.mWindowManager.mTransactionFactory.get();