Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 466b665a authored by Chalard Jean's avatar Chalard Jean
Browse files

Make NetworkCapabilities authoritative for roaming state 

...instead of NetworkInfo

Bug: 138306002
Test: FrameworksNetTests FrameworksTelephonyTests
Change-Id: Ifdea19fa32089b5c7925f5010169b1dea3d2b304
parent fb342fcf

services/core/java/com/android/server/ConnectivityService.java

+7 −3
Original line number Diff line number Diff line
@@ -5848,9 +5848,10 @@ public class ConnectivityService extends IConnectivityManager.Stub 
        }

        newNc.setPrivateDnsBroken(nai.networkCapabilities.isPrivateDnsBroken());



        // TODO : remove this once all factories are updated to send NOT_SUSPENDED

        // TODO : remove this once all factories are updated to send NOT_SUSPENDED and NOT_ROAMING

        if (!newNc.hasTransport(TRANSPORT_CELLULAR)) {

            newNc.addCapability(NET_CAPABILITY_NOT_SUSPENDED);

            newNc.addCapability(NET_CAPABILITY_NOT_ROAMING);

        }



        return newNc;
@@ -5899,7 +5900,9 @@ public class ConnectivityService extends IConnectivityManager.Stub 
            processListenRequests(nai);

            final boolean prevSuspended = !prevNc.hasCapability(NET_CAPABILITY_NOT_SUSPENDED);

            final boolean suspended = !newNc.hasCapability(NET_CAPABILITY_NOT_SUSPENDED);

            if (prevSuspended != suspended) {

            final boolean prevRoaming = !prevNc.hasCapability(NET_CAPABILITY_NOT_ROAMING);

            final boolean roaming = !newNc.hasCapability(NET_CAPABILITY_NOT_ROAMING);

            if (prevSuspended != suspended || prevRoaming != roaming) {

                // TODO (b/73132094) : remove this call once the few users of onSuspended and

                // onResumed have been removed.

                notifyNetworkCallbacks(nai, suspended ? ConnectivityManager.CALLBACK_SUSPENDED
@@ -6615,7 +6618,7 @@ public class ConnectivityService extends IConnectivityManager.Stub 
    @NonNull

    private NetworkInfo mixInInfo(@NonNull final NetworkAgentInfo nai, @NonNull NetworkInfo info) {

        final NetworkInfo newInfo = new NetworkInfo(info);

        // The suspended bit is managed in NetworkCapabilities.

        // The suspended and roaming bits are managed in NetworkCapabilities.

        final boolean suspended =

                !nai.networkCapabilities.hasCapability(NET_CAPABILITY_NOT_SUSPENDED);

        if (suspended && info.getDetailedState() == NetworkInfo.DetailedState.CONNECTED) {
@@ -6628,6 +6631,7 @@ public class ConnectivityService extends IConnectivityManager.Stub 
            newInfo.setDetailedState(NetworkInfo.DetailedState.SUSPENDED, info.getReason(),

                    info.getExtraInfo());

        }

        newInfo.setRoaming(!nai.networkCapabilities.hasCapability(NET_CAPABILITY_NOT_ROAMING));

        return newInfo;

    }