Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 462c1d1f authored by Yi-an Chen's avatar Yi-an Chen
Browse files

Prevent some key system applications from losing storage permissions 

The storage permissions of some system applications have been authorized by default and cannot be modified by users with SYSTEM_FIXED or POLICY_FIXED flags. Once revoked due to an self-upgrade package, the user cannot re-grant.

Bug: 292732635
Test: build
Change-Id: I055ecc6a523f680b411505ed18d90deb0252bf85
parent 47b04d1b

services/permission/java/com/android/server/permission/access/permission/AppIdPermissionPolicy.kt

+4 −1
Original line number Diff line number Diff line
@@ -678,8 +678,11 @@ class AppIdPermissionPolicy : SchemePolicy() { 
            newState.userStates.forEachIndexed { _, userId, userState ->

                userState.appIdPermissionFlags[appId]?.forEachReversedIndexed {

                    _, permissionName, oldFlags ->

                    // Do not revoke the permission during an upgrade if it's POLICY_FIXED or

                    // SYSTEM_FIXED. Otherwise the user cannot grant back the permission.

                    if (permissionName in STORAGE_AND_MEDIA_PERMISSIONS &&

                        oldFlags.hasBits(PermissionFlags.RUNTIME_GRANTED)) {

                        oldFlags.hasBits(PermissionFlags.RUNTIME_GRANTED) &&

                        !oldFlags.hasAnyBit(SYSTEM_OR_POLICY_FIXED_MASK)) {

                        Slog.v(

                            LOG_TAG, "Revoking storage permission: $permissionName for appId: " +

                                " $appId and user: $userId"