Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 453e92f6 authored by Nipun Kwatra's avatar Nipun Kwatra
Browse files

When using still camera for time lapse capture, don't set preview. 

Since HD resolution may not be supported by the video camera,
don't set preivew using the HD size. The app should have set the
preview already, just use that.

Change-Id: I2f8e89bf2c7440f7bc8db7e4a228f4c8250d92b4
parent cffebf85

media/libmediaplayerservice/StagefrightRecorder.cpp

+7 −6
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ 
#include <surfaceflinger/ISurface.h>

#include <utils/Errors.h>

#include <sys/types.h>

#include <unistd.h>

#include <ctype.h>

#include <unistd.h>



#include "ARTPWriter.h"
@@ -929,9 +929,10 @@ status_t StagefrightRecorder::setupCameraSource() { 
    // Set the actual video recording frame size

    CameraParameters params(mCamera->getParameters());



    // dont change the preview size for time lapse as mVideoWidth, mVideoHeight

    // may correspond to HD resolution not supported by video camera.

    if (!mCaptureTimeLapse) {

    // dont change the preview size when using still camera for time lapse

    // as mVideoWidth, mVideoHeight may correspond to HD resolution not

    // supported by the video camera.

    if (!(mCaptureTimeLapse && mUseStillCameraForTimeLapse)) {

        params.setPreviewSize(mVideoWidth, mVideoHeight);

    }
@@ -947,7 +948,7 @@ status_t StagefrightRecorder::setupCameraSource() { 
    // Check on video frame size

    int frameWidth = 0, frameHeight = 0;

    newCameraParams.getPreviewSize(&frameWidth, &frameHeight);

    if (!mCaptureTimeLapse &&

    if (!(mCaptureTimeLapse && mUseStillCameraForTimeLapse) &&

        (frameWidth  < 0 || frameWidth  != mVideoWidth ||

        frameHeight < 0 || frameHeight != mVideoHeight)) {

        LOGE("Failed to set the video frame size to %dx%d",