Merge "Do not make ActivityContainer available to apps." (44e62ca8) · Commits · e / os / android_frameworks_base

core/java/android/app/ActivityManagerNative.java

+10 −19

Original line number	Diff line number	Diff line
		@@ -17,7 +17,6 @@
		package android.app;

		import android.app.ActivityManager.StackInfo;
		import android.app.ProfilerInfo;
		import android.content.ComponentName;
		import android.content.IIntentReceiver;
		import android.content.IIntentSender;
		@@ -2233,17 +2232,12 @@ public abstract class ActivityManagerNative extends Binder implements IActivityM
		return true;
		}

		case GET_ACTIVITY_CONTAINER_TRANSACTION: {
		case GET_ACTIVITY_DISPLAY_ID_TRANSACTION: {
		data.enforceInterface(IActivityManager.descriptor);
		IBinder activityToken = data.readStrongBinder();
		IActivityContainer activityContainer = getEnclosingActivityContainer(activityToken);
		int displayId = getActivityDisplayId(activityToken);
		reply.writeNoException();
		if (activityContainer != null) {
		reply.writeInt(1);
		reply.writeStrongBinder(activityContainer.asBinder());
		} else {
		reply.writeInt(0);
		}
		reply.writeInt(displayId);
		return true;
		}

		@@ -5298,6 +5292,7 @@ class ActivityManagerProxy implements IActivityManager
		reply.recycle();
		}

		@Override
		public IActivityContainer createStackOnDisplay(int displayId) throws RemoteException {
		Parcel data = Parcel.obtain();
		Parcel reply = Parcel.obtain();
		@@ -5317,26 +5312,22 @@ class ActivityManagerProxy implements IActivityManager
		return res;
		}

		public IActivityContainer getEnclosingActivityContainer(IBinder activityToken)
		@Override
		public int getActivityDisplayId(IBinder activityToken)
		throws RemoteException {
		Parcel data = Parcel.obtain();
		Parcel reply = Parcel.obtain();
		data.writeInterfaceToken(IActivityManager.descriptor);
		data.writeStrongBinder(activityToken);
		mRemote.transact(GET_ACTIVITY_CONTAINER_TRANSACTION, data, reply, 0);
		mRemote.transact(GET_ACTIVITY_DISPLAY_ID_TRANSACTION, data, reply, 0);
		reply.readException();
		final int result = reply.readInt();
		final IActivityContainer res;
		if (result == 1) {
		res = IActivityContainer.Stub.asInterface(reply.readStrongBinder());
		} else {
		res = null;
		}
		final int displayId = reply.readInt();
		data.recycle();
		reply.recycle();
		return res;
		return displayId;
		}

		@Override
		public IBinder getHomeActivityToken() throws RemoteException {
		Parcel data = Parcel.obtain();
		Parcel reply = Parcel.obtain();

core/java/android/app/ActivityThread.java

+1 −5

Original line number	Diff line number	Diff line
		@@ -2375,11 +2375,7 @@ public final class ActivityThread {
		private Context createBaseContextForActivity(ActivityClientRecord r, final Activity activity) {
		int displayId = Display.DEFAULT_DISPLAY;
		try {
		IActivityContainer container =
		ActivityManagerNative.getDefault().getEnclosingActivityContainer(r.token);
		if (container != null) {
		displayId = container.getDisplayId();
		}
		displayId = ActivityManagerNative.getDefault().getActivityDisplayId(r.token);
		} catch (RemoteException e) {
		}

core/java/android/app/IActivityManager.java

+2 −3

Original line number	Diff line number	Diff line
		@@ -445,8 +445,7 @@ public interface IActivityManager extends IInterface {

		public void deleteActivityContainer(IActivityContainer container) throws RemoteException;

		public IActivityContainer getEnclosingActivityContainer(IBinder activityToken)
		throws RemoteException;
		public int getActivityDisplayId(IBinder activityToken) throws RemoteException;

		public IBinder getHomeActivityToken() throws RemoteException;

		@@ -763,7 +762,7 @@ public interface IActivityManager extends IInterface {
		int GET_PERSISTED_URI_PERMISSIONS_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+181;
		int APP_NOT_RESPONDING_VIA_PROVIDER_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+182;
		int GET_HOME_ACTIVITY_TOKEN_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+183;
		int GET_ACTIVITY_CONTAINER_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+184;
		int GET_ACTIVITY_DISPLAY_ID_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+184;
		int DELETE_ACTIVITY_CONTAINER_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+185;

services/core/java/com/android/server/am/ActivityManagerService.java

+5 −5

Original line number	Diff line number	Diff line
		@@ -57,6 +57,7 @@ import android.util.ArrayMap;
		import android.util.ArraySet;
		import android.util.SparseIntArray;

		import android.view.Display;
		import com.android.internal.R;
		import com.android.internal.annotations.GuardedBy;
		import com.android.internal.app.IAppOpsService;
		@@ -8205,14 +8206,13 @@ public final class ActivityManagerService extends ActivityManagerNative
		}

		@Override
		public IActivityContainer getEnclosingActivityContainer(IBinder activityToken)
		throws RemoteException {
		public int getActivityDisplayId(IBinder activityToken) throws RemoteException {
		synchronized (this) {
		ActivityStack stack = ActivityRecord.getStackLocked(activityToken);
		if (stack != null) {
		return stack.mActivityContainer;
		if (stack != null && stack.mActivityContainer.isAttachedLocked()) {
		return stack.mActivityContainer.getDisplayId();
		}
		return null;
		return Display.DEFAULT_DISPLAY;
		}
		}