Commit 44dc8b1d authored Jan 25, 2018 by Michael Wright

Clear pending brightness setting when it's redundant.

If we don't clear the pending brightness setting when it's equivalent to
the existing brightness setting then we end up racing the next time
auto-brightness changes. Most of the time the settings change
notification will win and we'll ignore the stale pending brightness, but
sometimes we immediately update the power state again and then we'll see
the stale value which looks different from our current value and so
assume it's a change coming from the user. Whoops.

Bug: 72508527
Test: manual
Change-Id: Id743f3654be6d48a14fca5882c1b8e16fed147da

parent d55e3e75

services/core/java/com/android/server/display/DisplayPowerController.java

+1 −0

Original line number	Diff line number	Diff line
		@@ -1449,6 +1449,7 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call
		return false;
		}
		if (mCurrentScreenBrightnessSetting == mPendingScreenBrightnessSetting) {
		mPendingScreenBrightnessSetting = -1;
		return false;
		}
		mLastUserSetScreenBrightness = mPendingScreenBrightnessSetting;