Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4472fa97 authored by Kenji Sugimoto's avatar Kenji Sugimoto Committed by Craig Mautner
Browse files

Prevent ANR when broadcast receiver is killed

If the process of a BroacastReceiver is dying at the same time
as the system is trying to send an ordered broadcast to the
receiver, the system will try to start the process again. The
BroadcastQueue will store the BroadcastRecord in mPendingBroadcast
to be able to handle it again when the process is awake. A
timeout Message is posted to the handler of the BroadcastQueue.

As part of the shutdown sequence skipCurrentReceiver is called for
the ProcessRecord. This will check if there is a curReceiver set
for the application and make sure to finish the receiver.

Each of the foreground and background BroadcastQueues have their
own handler for managing broadcast timeouts. If the wrong
BroadcastQueue finishes the receiver, the pending timeout Message
will never be cancelled, leading to an ANR report for a receiver
that has already been finished.

Change-Id: I960c0d8f1a8b739b54a8f09f496b32a3498b9e9a
parent ccce6e0f
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -296,7 +296,7 @@ public final class BroadcastQueue {
    public void skipCurrentReceiverLocked(ProcessRecord app) {
    public void skipCurrentReceiverLocked(ProcessRecord app) {
        boolean reschedule = false;
        boolean reschedule = false;
        BroadcastRecord r = app.curReceiver;
        BroadcastRecord r = app.curReceiver;
        if (r != null) {
        if (r != null && r.queue == this) {
            // The current broadcast is waiting for this app's receiver
            // The current broadcast is waiting for this app's receiver
            // to be finished.  Looks like that's not going to happen, so
            // to be finished.  Looks like that's not going to happen, so
            // let the broadcast continue.
            // let the broadcast continue.