Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 446166d7 authored by Fabian Kozynski's avatar Fabian Kozynski
Browse files

Remove flags for wallet and alarm 

Flags are no longer needed.

Test: disable flags
Test: atest QuickAccessWalletTileTest AlarmTileTest
Fixes: 190467517
Change-Id: Iae2d1a8b46a5fcd5efb76c1966c7f9822a04104a
parent cf3e019b

packages/SystemUI/res/values/flags.xml

+0 −4
Original line number Original line Diff line number Diff line
@@ -33,15 +33,11 @@ 
    <!-- People Tile flag -->

    <!-- People Tile flag -->

    <bool name="flag_conversations">false</bool>

    <bool name="flag_conversations">false</bool>





    <bool name="flag_wallet">false</bool>



    <!-- The new animations to/from lockscreen and AOD! -->

    <!-- The new animations to/from lockscreen and AOD! -->

    <bool name="flag_lockscreen_animations">false</bool>

    <bool name="flag_lockscreen_animations">false</bool>





    <bool name="flag_pm_lite">true</bool>

    <bool name="flag_pm_lite">true</bool>





    <bool name="flag_alarm_tile">false</bool>



    <bool name="flag_charging_ripple">false</bool>

    <bool name="flag_charging_ripple">false</bool>





    <bool name="flag_ongoing_call_status_bar_chip">true</bool>

    <bool name="flag_ongoing_call_status_bar_chip">true</bool>

packages/SystemUI/src/com/android/systemui/qs/tiles/AlarmTile.kt

+0 −6
Original line number Original line Diff line number Diff line
@@ -24,7 +24,6 @@ import com.android.systemui.qs.QSHost 
import com.android.systemui.qs.logging.QSLogger

import com.android.systemui.qs.logging.QSLogger

import com.android.systemui.qs.tileimpl.QSTileImpl

import com.android.systemui.qs.tileimpl.QSTileImpl

import com.android.systemui.settings.UserTracker

import com.android.systemui.settings.UserTracker

import com.android.systemui.statusbar.FeatureFlags

import com.android.systemui.statusbar.policy.NextAlarmController

import com.android.systemui.statusbar.policy.NextAlarmController

import java.util.Locale

import java.util.Locale

import javax.inject.Inject

import javax.inject.Inject
@@ -38,7 +37,6 @@ class AlarmTile @Inject constructor( 
    statusBarStateController: StatusBarStateController,

    statusBarStateController: StatusBarStateController,

    activityStarter: ActivityStarter,

    activityStarter: ActivityStarter,

    qsLogger: QSLogger,

    qsLogger: QSLogger,

    private val featureFlags: FeatureFlags,

    private val userTracker: UserTracker,

    private val userTracker: UserTracker,

    nextAlarmController: NextAlarmController

    nextAlarmController: NextAlarmController

) : QSTileImpl<QSTile.State>(

) : QSTileImpl<QSTile.State>(
@@ -65,10 +63,6 @@ class AlarmTile @Inject constructor( 
        nextAlarmController.observe(this, callback)

        nextAlarmController.observe(this, callback)

    }

    }





    override fun isAvailable(): Boolean {

        return featureFlags.isAlarmTileAvailable

    }



    override fun newTileState(): QSTile.State {

    override fun newTileState(): QSTile.State {

        return QSTile.State().apply {

        return QSTile.State().apply {

            handlesLongClick = false

            handlesLongClick = false

packages/SystemUI/src/com/android/systemui/qs/tiles/QuickAccessWalletTile.java

+2 −7
Original line number Original line Diff line number Diff line
@@ -49,7 +49,6 @@ import com.android.systemui.plugins.statusbar.StatusBarStateController; 
import com.android.systemui.qs.QSHost;

import com.android.systemui.qs.QSHost;

import com.android.systemui.qs.logging.QSLogger;

import com.android.systemui.qs.logging.QSLogger;

import com.android.systemui.qs.tileimpl.QSTileImpl;

import com.android.systemui.qs.tileimpl.QSTileImpl;

import com.android.systemui.statusbar.FeatureFlags;

import com.android.systemui.statusbar.policy.KeyguardStateController;

import com.android.systemui.statusbar.policy.KeyguardStateController;

import com.android.systemui.util.settings.SecureSettings;

import com.android.systemui.util.settings.SecureSettings;

import com.android.systemui.wallet.controller.QuickAccessWalletController;

import com.android.systemui.wallet.controller.QuickAccessWalletController;
@@ -71,7 +70,6 @@ public class QuickAccessWalletTile extends QSTileImpl<QSTile.State> { 
    private final PackageManager mPackageManager;

    private final PackageManager mPackageManager;

    private final SecureSettings mSecureSettings;

    private final SecureSettings mSecureSettings;

    private final QuickAccessWalletController mController;

    private final QuickAccessWalletController mController;

    private final FeatureFlags mFeatureFlags;





    private WalletCard mSelectedCard;

    private WalletCard mSelectedCard;

    @VisibleForTesting Drawable mCardViewDrawable;

    @VisibleForTesting Drawable mCardViewDrawable;
@@ -89,15 +87,13 @@ public class QuickAccessWalletTile extends QSTileImpl<QSTile.State> { 
            KeyguardStateController keyguardStateController,

            KeyguardStateController keyguardStateController,

            PackageManager packageManager,

            PackageManager packageManager,

            SecureSettings secureSettings,

            SecureSettings secureSettings,

            QuickAccessWalletController quickAccessWalletController,

            QuickAccessWalletController quickAccessWalletController) {

            FeatureFlags featureFlags) {

        super(host, backgroundLooper, mainHandler, falsingManager, metricsLogger,

        super(host, backgroundLooper, mainHandler, falsingManager, metricsLogger,

                statusBarStateController, activityStarter, qsLogger);

                statusBarStateController, activityStarter, qsLogger);

        mController = quickAccessWalletController;

        mController = quickAccessWalletController;

        mKeyguardStateController = keyguardStateController;

        mKeyguardStateController = keyguardStateController;

        mPackageManager = packageManager;

        mPackageManager = packageManager;

        mSecureSettings = secureSettings;

        mSecureSettings = secureSettings;

        mFeatureFlags = featureFlags;

    }

    }
@@ -192,8 +188,7 @@ public class QuickAccessWalletTile extends QSTileImpl<QSTile.State> { 




    @Override

    @Override

    public boolean isAvailable() {

    public boolean isAvailable() {

        return mFeatureFlags.isQuickAccessWalletEnabled()

        return mPackageManager.hasSystemFeature(PackageManager.FEATURE_NFC_HOST_CARD_EMULATION)

                && mPackageManager.hasSystemFeature(PackageManager.FEATURE_NFC_HOST_CARD_EMULATION)

                && !mPackageManager.hasSystemFeature(FEATURE_CHROME_OS)

                && !mPackageManager.hasSystemFeature(FEATURE_CHROME_OS)

                && mSecureSettings.getString(NFC_PAYMENT_DEFAULT_COMPONENT) != null;

                && mSecureSettings.getString(NFC_PAYMENT_DEFAULT_COMPONENT) != null;

    }

    }

packages/SystemUI/src/com/android/systemui/statusbar/FeatureFlags.java

+0 −8
Original line number Original line Diff line number Diff line
@@ -65,18 +65,10 @@ public class FeatureFlags { 
        return mFlagReader.isEnabled(R.bool.flag_monet);

        return mFlagReader.isEnabled(R.bool.flag_monet);

    }

    }





    public boolean isQuickAccessWalletEnabled() {

        return mFlagReader.isEnabled(R.bool.flag_wallet);

    }



    public boolean isPMLiteEnabled() {

    public boolean isPMLiteEnabled() {

        return mFlagReader.isEnabled(R.bool.flag_pm_lite);

        return mFlagReader.isEnabled(R.bool.flag_pm_lite);

    }

    }





    public boolean isAlarmTileAvailable() {

        return mFlagReader.isEnabled(R.bool.flag_alarm_tile);

    }



    public boolean isChargingRippleEnabled() {

    public boolean isChargingRippleEnabled() {

        return mFlagReader.isEnabled(R.bool.flag_charging_ripple);

        return mFlagReader.isEnabled(R.bool.flag_charging_ripple);

    }

    }

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java

+1 −4
Original line number Original line Diff line number Diff line
@@ -1126,11 +1126,8 @@ public class NotificationPanelViewController extends PanelViewController { 
        mKeyguardBottomArea.setStatusBar(mStatusBar);

        mKeyguardBottomArea.setStatusBar(mStatusBar);

        mKeyguardBottomArea.setUserSetupComplete(mUserSetupComplete);

        mKeyguardBottomArea.setUserSetupComplete(mUserSetupComplete);

        mKeyguardBottomArea.setFalsingManager(mFalsingManager);

        mKeyguardBottomArea.setFalsingManager(mFalsingManager);



        if (mFeatureFlags.isQuickAccessWalletEnabled()) {

        mKeyguardBottomArea.initWallet(mQuickAccessWalletController);

        mKeyguardBottomArea.initWallet(mQuickAccessWalletController);

    }

    }

    }





    private void updateMaxDisplayedNotifications(boolean recompute) {

    private void updateMaxDisplayedNotifications(boolean recompute) {

        if (recompute) {

        if (recompute) {